Re: [PATCH 5/5] d3d9/tests: Improve the shade mode test.

[Henri Verbeet]

On 8 November 2015 at 20:25, Matteo Bruni  wrote:
> dlls/d3d9/tests/visual.c | 275 ++++++++++++++++++++++++++++++++---------------
>  1 file changed, 191 insertions(+), 84 deletions(-)

I think most of this test would work for d3d8 and ddraw as well. Could
you please port it?
> -
>    {&novs, &ps_3, D3DPT_TRIANGLESTRIP, D3DSHADE_FLAT,    FALSE, 0x00ff0000, 0x0000ff00},
> -
>    {&novs, &ps_3, D3DPT_TRIANGLESTRIP, D3DSHADE_GOURAUD, FALSE, 0x000dca28, 0x000d45c7},

These fail here on Windows:
    visual.c:8338: Test failed: Test 14 shading has color0 00ffffff,
expected 00ff0000.
    visual.c:8340: Test failed: Test 14 shading has color1 00ffffff,
expected 0000ff00.
    visual.c:8338: Test failed: Test 15 shading has color0 00ffffff,
expected 000dca28.
    visual.c:8340: Test failed: Test 15 shading has color1 00ffffff,
expected 000d45c7.

IIRC SM3 vertex and pixel shaders need to be used together, or results
are undefined / implementation defined.

[PATCH 5/5] d3d9/tests: Improve the shade mode test.

[Matteo Bruni]

2015-11-09 13:10 GMT+01:00 Henri Verbeet :
> On 8 November 2015 at 20:25, Matteo Bruni  wrote:
> > dlls/d3d9/tests/visual.c | 275 ++++++++++++++++++++++++++++++++---------------
> >  1 file changed, 191 insertions(+), 84 deletions(-)
>
> I think most of this test would work for d3d8 and ddraw as well. Could
> you please port it?

I have the d3d8 test around. I'm going to port it to ddraw too.
> > -
> >    {&novs, &ps_3, D3DPT_TRIANGLESTRIP, D3DSHADE_FLAT,    FALSE, 0x00ff0000, 0x0000ff00},
> > -
> >    {&novs, &ps_3, D3DPT_TRIANGLESTRIP, D3DSHADE_GOURAUD, FALSE, 0x000dca28, 0x000d45c7},
>
> These fail here on Windows:
>     visual.c:8338: Test failed: Test 14 shading has color0 00ffffff,
> expected 00ff0000.
>     visual.c:8340: Test failed: Test 14 shading has color1 00ffffff,
> expected 0000ff00.
>     visual.c:8338: Test failed: Test 15 shading has color0 00ffffff,
> expected 000dca28.
>     visual.c:8340: Test failed: Test 15 shading has color1 00ffffff,
> expected 000d45c7.
>
> IIRC SM3 vertex and pixel shaders need to be used together, or results
> are undefined / implementation defined.

Right, I forgot to rerun the test on AMD entirely since I last changed it...