New subject: [PATCH] msvcr120: Add remainder (try3)

6 Apr 2016


      Hi Daniel,
On 04/06/16 01:00, Daniel Lehman wrote:
...
Try2: handle y==0
Try3: add tests and error handling for both x and y, but I have a question:
Based on the tests, remainder on 32-bit Windows differs from 64-bit Windows in errno handling.  Other math functions, like acosf, behave the same - if tests for it were added, the current Wine implementation would differ from 32-bit Windows
The #ifdef is admittedly ugly but makes it match both Windows 32-bit and 64-bit
is it preferable to match Windows exactly?  or could I drop the #ifdef and use the 64-bit errno handling, like acosf?  could I skip the tests that differ on 32-bit?
It depends on the function. In this case I don't think anything bad will 
happen if errno is set on invalid input even so it's not on Windows. I 
think it's OK to ignore the difference in this case and run some tests 
only in 32-bit or 64-bit environment. If you decide to be not fully 
compatible with native - please leave a comment in code.
Currently the tests are not working on wine (both i386 and x86_64).
Thanks,
Piotr

Re: [PATCH] msvcr120: Add remainder (try3)