Re: secur32: Add support for ECDHE algorithms using gnutls

[Jacek Caban]

Hi Sean,

On 12/30/14 00:08, Sean Burke wrote:
> diff --git a/dlls/secur32/schannel_gnutls.c b/dlls/secur32/schannel_gnutls.c
> index 638b3c5..810c598 100644
> --- a/dlls/secur32/schannel_gnutls.c
> +++ b/dlls/secur32/schannel_gnutls.c
> @@ -328,6 +328,8 @@ static ALG_ID schannel_get_kx_algid(gnutls_kx_algorithm_t kx)
>      switch (kx)
>      {
>          case GNUTLS_KX_RSA: return CALG_RSA_KEYX;
> -
>    case GNUTLS_KX_ECDHE_ECDSA:

Shouldn't this case use CALG_ECDSA?
> -
>    case GNUTLS_KX_ECDHE_RSA: return CALG_ECDH;
>    case GNUTLS_KX_DHE_DSS:
>    case GNUTLS_KX_DHE_RSA: return CALG_DH_EPHEM;
> default:

Cheers,
Jacek

secur32: Add support for ECDHE algorithms using gnutls

[Seán de Búrca]

Hi Jacek,

On 12/30/14 08:34, Jacek Caban wrote:
> Hi Sean,
> On 12/30/14 00:08, Sean Burke wrote:
> > /  diff --git a/dlls/secur32/schannel_gnutls.c b/dlls/secur32/schannel_gnutls.c

/>>/  index 638b3c5..810c598 100644
/>>/  --- a/dlls/secur32/schannel_gnutls.c
/>>/  +++ b/dlls/secur32/schannel_gnutls.c
/>>/  @@ -328,6 +328,8 @@ static ALG_ID schannel_get_kx_algid(gnutls_kx_algorithm_t kx)
/>>/       switch (kx)
/>>/       {
/>>/           case GNUTLS_KX_RSA: return CALG_RSA_KEYX;
/>>/  +        case GNUTLS_KX_ECDHE_ECDSA:
/
> Shouldn't this case use CALG_ECDSA?

It's possible. I based this on dlls/secur32/schannel_macosx.c:501, where _ECDHE_ECDSA returns CALG_ECDH. If this is incorrect, please let me know.
> > /  +        case GNUTLS_KX_ECDHE_RSA: return CALG_ECDH;

/>>/           case GNUTLS_KX_DHE_DSS:
/>>/           case GNUTLS_KX_DHE_RSA: return CALG_DH_EPHEM;
/>>/       default:
/
> Cheers,
> Jacek

Sean Burke