Re: [PATCH 6/7] wined3d: Avoid reading uninitialized texcoord varyings in FFP replacement fragment shaders.

[Henri Verbeet]

On 2 October 2015 at 14:54, Matteo Bruni  wrote:
> - unsigned char padding;
> - unsigned char pointsprite : 1;
> - unsigned char padding : 7;
> - unsigned int inited_texcoords;
>
> };

Did you perhaps mean something like "initialized_texcoords" or
"texcoords_initialized"?

[PATCH 6/7] wined3d: Avoid reading uninitialized texcoord varyings in FFP replacement fragment shaders.

[Matteo Bruni]

2015-10-05 11:49 GMT+02:00 Henri Verbeet :
> On 2 October 2015 at 14:54, Matteo Bruni  wrote:
> > - unsigned char padding;
> > - unsigned char pointsprite : 1;
> > - unsigned char padding : 7;
> > - unsigned int inited_texcoords;
> >
> > };
>
> Did you perhaps mean something like "initialized_texcoords" or
> "texcoords_initialized"?

Yes. Which one do you prefer?

[PATCH 6/7] wined3d: Avoid reading uninitialized texcoord varyings in FFP replacement fragment shaders.

[Henri Verbeet]

On 5 October 2015 at 12:39, Matteo Bruni  wrote:
> 2015-10-05 11:49 GMT+02:00 Henri Verbeet :
> > On 2 October 2015 at 14:54, Matteo Bruni  wrote:
> > > - unsigned char padding;
> > > - unsigned char pointsprite : 1;
> > > - unsigned char padding : 7;
> > > - unsigned int inited_texcoords;
> > >
> > > };
> >
> > Did you perhaps mean something like "initialized_texcoords" or
> > "texcoords_initialized"?
>
> Yes. Which one do you prefer?

The latter, but only slightly.