Re: [2/3] msxml3: Validate node content in xmlnode_put_dataType() (resend)

[Jacek Caban]

On 11/19/10 6:22 AM, Adam Martinson wrote:
> dlls/msxml3/msxml_private.h |    1 +
>  dlls/msxml3/node.c          |  113 
> ++++++++++++++++++++++++++-----------------
>  dlls/msxml3/schema.c        |   94 +++++++++++++++++++++++++++++++++--
>  3 files changed, 158 insertions(+), 50 deletions(-)

@@ -887,71 +891,92 @@ static HRESULT WINAPI xmlnode_put_dataType(
  {
      xmlnode *This = impl_from_IXMLDOMNode( iface );
      HRESULT hr = E_FAIL;
+    xmlChar *str;
+    XDR_DT dt;

TRACE("(%p)->(%s)\n", This, debugstr_w(dataTypeName));

if(dataTypeName == NULL)
          return E_INVALIDARG;

+    if (This->node->type != XML_ELEMENT_NODE)
+        return E_FAIL;

Again, this should go to element object then.

Jacek