Signed-off-by: Jacek Caban jacek@codeweavers.com --- In this context, Vulkan driver is not dependent on DC.
dlls/d3d12/d3d12_main.c | 6 +----- dlls/dxgi/swapchain.c | 6 +----- dlls/user32/driver.c | 2 ++ dlls/win32u/dibdrv/dc.c | 2 -- dlls/win32u/driver.c | 18 ++++++++++++------ dlls/win32u/emfdrv.c | 1 - dlls/win32u/font.c | 1 - dlls/win32u/path.c | 1 - dlls/win32u/vulkan.c | 15 +++------------ dlls/win32u/win32u.spec | 2 +- dlls/win32u/win32u_private.h | 2 +- dlls/win32u/wrappers.c | 4 ++-- dlls/wined3d/adapter_vk.c | 5 +---- dlls/winemac.drv/gdi.c | 2 +- dlls/winemac.drv/macdrv.h | 2 +- dlls/winemac.drv/vulkan.c | 11 ++--------- dlls/wineps.drv/init.c | 1 - dlls/winevulkan/loader.c | 5 +---- dlls/winevulkan/make_vulkan | 2 +- dlls/winex11.drv/init.c | 13 +++---------- dlls/winex11.drv/xrender.c | 1 - include/wine/gdi_driver.h | 7 ++++--- include/wine/vulkan_driver.h | 2 +- 23 files changed, 38 insertions(+), 73 deletions(-)
Hi,
While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check?
Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=103547
Your paranoid android.
=== debiant2 (32 bit Chinese:China report) ===
dxgi: dxgi.c:2614: Test failed: Got monitor rect (0,0)-(800,600), expected (0,0)-(1024,768). dxgi.c:2618: Test failed: Got monitor rect (0,0)-(800,600), expected (0,0)-(1024,768). dxgi.c:2687: Test failed: Got monitor rect (0,0)-(800,600), expected (0,0)-(1024,768). dxgi.c:2694: Test failed: Got monitor rect (0,0)-(800,600), expected (0,0)-(1024,768). dxgi.c:2687: Test failed: Got monitor rect (0,0)-(800,600), expected (0,0)-(1024,768). dxgi.c:2694: Test failed: Got monitor rect (0,0)-(800,600), expected (0,0)-(1024,768). dxgi.c:2709: Test failed: Got monitor rect (0,0)-(800,600), expected (0,0)-(1024,768). dxgi.c:2874: Test failed: Got monitor rect (0,0)-(800,600), expected (0,0)-(1024,768).
=== debiant2 (32 bit WoW report) ===
dxgi: dxgi.c:3354: Test failed: Got monitor rect (0,0)-(1280,1024), expected (0,0)-(1024,768). dxgi.c:3356: Test failed: Got monitor rect (0,0)-(1280,1024), expected (0,0)-(1024,768). dxgi.c:3369: Test failed: Got monitor rect (0,0)-(1280,1024), expected (0,0)-(1024,768). dxgi.c:7144: Test failed: Got a different mode. dxgi.c:7147: Test failed: Got a different mode. dxgi.c:7209: Test failed: Got a different mode.
=== debiant2 (64 bit WoW report) ===
dxgi: dxgi.c:3354: Test failed: Got monitor rect (0,0)-(1280,960), expected (0,0)-(1280,1024). dxgi.c:3356: Test failed: Got monitor rect (0,0)-(1280,960), expected (0,0)-(1280,1024). dxgi.c:3369: Test failed: Got monitor rect (0,0)-(1280,960), expected (0,0)-(1280,1024).
On Tue, Dec 07, 2021 at 10:01:12AM -0600, Marvin wrote:
Hi,
While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check?
Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=103547
Your paranoid android.
=== debiant2 (32 bit Chinese:China report) ===
dxgi: dxgi.c:2614: Test failed: Got monitor rect (0,0)-(800,600), expected (0,0)-(1024,768). dxgi.c:2618: Test failed: Got monitor rect (0,0)-(800,600), expected (0,0)-(1024,768). dxgi.c:2687: Test failed: Got monitor rect (0,0)-(800,600), expected (0,0)-(1024,768). dxgi.c:2694: Test failed: Got monitor rect (0,0)-(800,600), expected (0,0)-(1024,768). dxgi.c:2687: Test failed: Got monitor rect (0,0)-(800,600), expected (0,0)-(1024,768). dxgi.c:2694: Test failed: Got monitor rect (0,0)-(800,600), expected (0,0)-(1024,768). dxgi.c:2709: Test failed: Got monitor rect (0,0)-(800,600), expected (0,0)-(1024,768). dxgi.c:2874: Test failed: Got monitor rect (0,0)-(800,600), expected (0,0)-(1024,768).
These look new, right?
Huw.
Huw Davies huw@codeweavers.com writes:
On Tue, Dec 07, 2021 at 10:01:12AM -0600, Marvin wrote:
Hi,
While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check?
Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=103547
Your paranoid android.
=== debiant2 (32 bit Chinese:China report) ===
dxgi: dxgi.c:2614: Test failed: Got monitor rect (0,0)-(800,600), expected (0,0)-(1024,768). dxgi.c:2618: Test failed: Got monitor rect (0,0)-(800,600), expected (0,0)-(1024,768). dxgi.c:2687: Test failed: Got monitor rect (0,0)-(800,600), expected (0,0)-(1024,768). dxgi.c:2694: Test failed: Got monitor rect (0,0)-(800,600), expected (0,0)-(1024,768). dxgi.c:2687: Test failed: Got monitor rect (0,0)-(800,600), expected (0,0)-(1024,768). dxgi.c:2694: Test failed: Got monitor rect (0,0)-(800,600), expected (0,0)-(1024,768). dxgi.c:2709: Test failed: Got monitor rect (0,0)-(800,600), expected (0,0)-(1024,768). dxgi.c:2874: Test failed: Got monitor rect (0,0)-(800,600), expected (0,0)-(1024,768).
These look new, right?
They happen occasionally, so it's not caused by this specific patch. It may be caused by the win32u changes in general though, possibly because of timings differences. At least I don't remember seeing these before the win32u migration started.
On 12/7/21 10:11 PM, Alexandre Julliard wrote:
Huw Davies huw@codeweavers.com writes:
On Tue, Dec 07, 2021 at 10:01:12AM -0600, Marvin wrote:
Hi,
While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check?
Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=103547
Your paranoid android.
=== debiant2 (32 bit Chinese:China report) ===
dxgi: dxgi.c:2614: Test failed: Got monitor rect (0,0)-(800,600), expected (0,0)-(1024,768). dxgi.c:2618: Test failed: Got monitor rect (0,0)-(800,600), expected (0,0)-(1024,768). dxgi.c:2687: Test failed: Got monitor rect (0,0)-(800,600), expected (0,0)-(1024,768). dxgi.c:2694: Test failed: Got monitor rect (0,0)-(800,600), expected (0,0)-(1024,768). dxgi.c:2687: Test failed: Got monitor rect (0,0)-(800,600), expected (0,0)-(1024,768). dxgi.c:2694: Test failed: Got monitor rect (0,0)-(800,600), expected (0,0)-(1024,768). dxgi.c:2709: Test failed: Got monitor rect (0,0)-(800,600), expected (0,0)-(1024,768). dxgi.c:2874: Test failed: Got monitor rect (0,0)-(800,600), expected (0,0)-(1024,768).
These look new, right?
They happen occasionally, so it's not caused by this specific patch. It may be caused by the win32u changes in general though, possibly because of timings differences. At least I don't remember seeing these before the win32u migration started.
I don't see this one, but I've seen similar problem of synchronization between caches before I moved monitor cache to win32u. It seemed to me that depending on registry write time resolution is not good enough. If that's right, then it's not really new, except that the new code requires fewer server calls, so may be more likely to hit the problem. Something like the attached patch could help in this case, but in theory it's similar between different processes.
Thanks,
Jacek
-
Alexandre Julliard -
Huw Davies -
Jacek Caban -
Marvin