Re: INI File Processing Improvements

[Dmitry Timoshkov]

"Robert Shearman"  wrote:
> Changelog:
> - Use Win32 instead of Unix file functions
> - Process files fully in Unicode
> - Add Unicode file detection

Further concerns:

1. You are duplicating too much unicode helpers already existing in
wine_unicode and include/wine/unicode.h
2. Are you sure that Windows supports unicode .ini files at all?

INI File Processing Improvements

[Robert Shearman]

> "Robert Shearman"  wrote:
> > Changelog:
> > - Use Win32 instead of Unix file functions
> > - Process files fully in Unicode
> > - Add Unicode file detection
>
> Further concerns:
> - You are duplicating too much unicode helpers already existing in
>
> wine_unicode and include/wine/unicode.h

There are no strnchrW and strnrchrW routines in unicode.h, so how do you
propose I rewrite memchrW and memrchrW?
> - Are you sure that Windows supports unicode .ini files at all?

Yes. I have and Windows2000 and above installer that uses
GetPrivateProfileString on Unicode text files to get its settings. I could
send you these files if you want.

Rob

INI File Processing Improvements

[Dmitry Timoshkov]

"Robert Shearman"  wrote:
> > - You are duplicating too much unicode helpers already existing in
> >
> > wine_unicode and include/wine/unicode.h
>
> There are no strnchrW and strnrchrW routines in unicode.h, so how do you
> propose I rewrite memchrW and memrchrW?

Perhaps just add them into wine/unicode.h
> > - Are you sure that Windows supports unicode .ini files at all?
>
> Yes. I have and Windows2000 and above installer that uses
> GetPrivateProfileString on Unicode text files to get its settings. I could
> send you these files if you want.

I assume they have the same format as unicode .reg files, right?

INI File Processing Improvements

[Robert Shearman]

> "Robert Shearman"  wrote:
> > > - You are duplicating too much unicode helpers already existing in
> > >
> > > wine_unicode and include/wine/unicode.h
> >
> > There are no strnchrW and strnrchrW routines in unicode.h, so how do you
> > propose I rewrite memchrW and memrchrW?
>
> Perhaps just add them into wine/unicode.h

I don't really think they belong there, as they don't map to any standard
libc functions. However, if people think they will be useful if added I will
submit a patch to add them.
> > > - Are you sure that Windows supports unicode .ini files at all?
> >
> > Yes. I have and Windows2000 and above installer that uses
> > GetPrivateProfileString on Unicode text files to get its
>
> settings. I could
> > send you these files if you want.
>
> I assume they have the same format as unicode .reg files, right?

Yes.
> --
> Dmitry.

INI File Processing Improvements

[Dmitry Timoshkov]

"Robert Shearman"  wrote:
> > > > - You are duplicating too much unicode helpers already existing in
> > > >
> > > > wine_unicode and include/wine/unicode.h
> > >
> > > There are no strnchrW and strnrchrW routines in unicode.h, so how do you
> > > propose I rewrite memchrW and memrchrW?
> >
> > Perhaps just add them into wine/unicode.h
>
> I don't really think they belong there, as they don't map to any standard
> libc functions. However, if people think they will be useful if added I will
> submit a patch to add them.

Submit the patch in the form as you wish. Alexandre will either accept
the patch and fix some minor cases, or will explain what you need to change
in it to make the patch acceptable for inclusion.