Re: [PATCH] api-ms-win-core-console-l2-1-0: Add stub dll.

[Hugh McMaster]

On Wednesday, 17 August 2016 8:39 PM, Hadrien Boizard wrote:
> +@ stub AttachConsole
> +@ stub CreateConsoleScreenBuffer
> +@ stub FillConsoleOutputAttribute
> +@ stub FillConsoleOutputCharacterA
> +@ stub FillConsoleOutputCharacterW
> +@ stub FlushConsoleInputBuffer
> +@ stub FreeConsole
> +@ stub GenerateConsoleCtrlEvent
> +@ stub GetConsoleCursorInfo
> +@ stub GetConsoleScreenBufferInfo
> +@ stub GetConsoleScreenBufferInfoEx
> +@ stub GetConsoleTitleW
> +@ stub GetLargestConsoleWindowSize
> +@ stub PeekConsoleInputW
> +@ stub ReadConsoleOutputA
> +@ stub ReadConsoleOutputAttribute
> +@ stub ReadConsoleOutputCharacterA
> +@ stub ReadConsoleOutputCharacterW
> +@ stub ReadConsoleOutputW
> +@ stub ScrollConsoleScreenBufferA
> +@ stub ScrollConsoleScreenBufferW
> +@ stub SetConsoleActiveScreenBuffer
> +@ stub SetConsoleCP
> +@ stub SetConsoleCursorInfo
> +@ stub SetConsoleCursorPosition
> +@ stub SetConsoleOutputCP
> +@ stub SetConsoleScreenBufferInfoEx
> +@ stub SetConsoleScreenBufferSize
> +@ stub SetConsoleTextAttribute
> +@ stub SetConsoleTitleW
> +@ stub SetConsoleWindowInfo
> +@ stub WriteConsoleInputA
> +@ stub WriteConsoleInputW
> +@ stub WriteConsoleOutputA
> +@ stub WriteConsoleOutputAttribute
> +@ stub WriteConsoleOutputCharacterA
> +@ stub WriteConsoleOutputCharacterW
> +@ stub WriteConsoleOutputW

Hi Hadrien,

Most, if not all, of these functions are implemented in dlls/kernel32.
You should forward these calls to kernel32, making sure to change
'stub' to 'stdcall' as necessary.

--
Hugh McMaster

[PATCH] api-ms-win-core-console-l2-1-0: Add stub dll.

[Michael Stefaniuc]

On 08/18/2016 11:33 AM, Hugh McMaster wrote:
> On Wednesday, 17 August 2016 8:39 PM, Hadrien Boizard wrote:
> > +@ stub AttachConsole
> > +@ stub CreateConsoleScreenBuffer
> > +@ stub FillConsoleOutputAttribute
> > +@ stub FillConsoleOutputCharacterA
> > +@ stub FillConsoleOutputCharacterW
> > +@ stub FlushConsoleInputBuffer
> > +@ stub FreeConsole
> > +@ stub GenerateConsoleCtrlEvent
> > +@ stub GetConsoleCursorInfo
> > +@ stub GetConsoleScreenBufferInfo
> > +@ stub GetConsoleScreenBufferInfoEx
> > +@ stub GetConsoleTitleW
> > +@ stub GetLargestConsoleWindowSize
> > +@ stub PeekConsoleInputW
> > +@ stub ReadConsoleOutputA
> > +@ stub ReadConsoleOutputAttribute
> > +@ stub ReadConsoleOutputCharacterA
> > +@ stub ReadConsoleOutputCharacterW
> > +@ stub ReadConsoleOutputW
> > +@ stub ScrollConsoleScreenBufferA
> > +@ stub ScrollConsoleScreenBufferW
> > +@ stub SetConsoleActiveScreenBuffer
> > +@ stub SetConsoleCP
> > +@ stub SetConsoleCursorInfo
> > +@ stub SetConsoleCursorPosition
> > +@ stub SetConsoleOutputCP
> > +@ stub SetConsoleScreenBufferInfoEx
> > +@ stub SetConsoleScreenBufferSize
> > +@ stub SetConsoleTextAttribute
> > +@ stub SetConsoleTitleW
> > +@ stub SetConsoleWindowInfo
> > +@ stub WriteConsoleInputA
> > +@ stub WriteConsoleInputW
> > +@ stub WriteConsoleOutputA
> > +@ stub WriteConsoleOutputAttribute
> > +@ stub WriteConsoleOutputCharacterA
> > +@ stub WriteConsoleOutputCharacterW
> > +@ stub WriteConsoleOutputW
>
> Hi Hadrien,
>
> Most, if not all, of these functions are implemented in dlls/kernel32.
> You should forward these calls to kernel32, making sure to change
> 'stub' to 'stdcall' as necessary.

He can just run the patched tools/make_specfiles and that will do it for
him.

bye
    michael