Re: [advapi32/tests #2] Add tests for OpenServiceA

[James Hawkins]

On 7/2/07, Paul Vriens  wrote:
> Hi,
>
> I've added some tests for OpenServiceA. Some of them crash on Wine, but I've
> opted to let them in (inside an if(0) though). The crashes happen because we
> assume that when a handle is not NULL it's correct.

The policy for crashing tests is that you need to fix the bug that
causes the tests to crash either before you send in the test patch or
in the same patch as the tests.  if(0) is only for tests that crash on
Windows.

[advapi32/tests #2] Add tests for OpenServiceA

[Paul Vriens]

James Hawkins wrote:
> On 7/2/07, Paul Vriens  wrote:
> > Hi,
> >
> > I've added some tests for OpenServiceA. Some of them crash on Wine, 
> > but I've
> > opted to let them in (inside an if(0) though). The crashes happen 
> > because we
> > assume that when a handle is not NULL it's correct.
>
> The policy for crashing tests is that you need to fix the bug that
> causes the tests to crash either before you send in the test patch or
> in the same patch as the tests.  if(0) is only for tests that crash on
> Windows.

Yeah, I guess I knew that. The only problem is that I'm currently in a 'writing 
tests' mode and the fixes were not as easy as I'd expected. I've also sent in 
some tests for CloseServiceHandle just now with the same if(0).

I guess I have to get back into 'bug fixing' mode then :-).

Cheers,

Paul.