Re: [PATCH 1/3] msvcrt: Added _mbsncoll and _mbsncoll_l implementation.

[Akihiro Sagawa]

On Fri, 19 Apr 2013 14:42:50 +0800, Jactry Zeng wrote:
> +/*********************************************************************
> -
> -
>          _mbsncoll_l(MSVCRT.@)
> - */
>
> +int CDECL _mbsncoll_l(const unsigned char *str1, const unsigned char *str2, MSVCRT_size_t count,
> -
>       MSVCRT__locale_t locale)
>
> +{
> - return _mbsnbcoll_l(str1, str2, count, locale);
>
> +}

According to MSDN, _mbsncoll_l receives a number of characters, but
_mbsnbcoll_l receives a number of bytes. This is a big difference in
multibyte code page.
So you should properly handle this situation, or add FIXME message based
on multibyte code page if your application just needs this function.

Regards,
Akihiro Sagawa

[PATCH 1/3] msvcrt: Added _mbsncoll and _mbsncoll_l implementation.

[Jactry Zeng]

Hi Akihiro,

2013/4/19 Akihiro Sagawa
> According to MSDN, _mbsncoll_l receives a number of characters, but
> _mbsnbcoll_l receives a number of bytes. This is a big difference in
> multibyte code page.
> So you should properly handle this situation, or add FIXME message based
> on multibyte code page if your application just needs this function.

Thanks for your review. :-)
I will tried to improve it.