Re: [2/14]hid: break HidD_ functions out into their own module

[Charles Davis]

> On Jun 25, 2015, at 9:15 AM, Aric Stewart  wrote:
> --- a/dlls/hid/main.c
> +++ b/dlls/hid/main.c
> @@ -39,43 +35,9 @@ BOOL WINAPI DllMain(HINSTANCE hInstDLL, DWORD fdwReason, LPVOID lpv)
>  {
>      switch(fdwReason)
>      {
> -
>    case DLL_WINE_PREATTACH:
> -
>        return FALSE;  /* prefer native version */

This is minor, but I don’t think we should prefer the builtin hid.dll until we’re done implementing it.

Chip

[2/14]hid: break HidD_ functions out into their own module

[Alexandre Julliard]

Charles Davis  writes:
> > On Jun 25, 2015, at 9:15 AM, Aric Stewart  wrote:
> > --- a/dlls/hid/main.c
> > +++ b/dlls/hid/main.c
> > @@ -39,43 +35,9 @@ BOOL WINAPI DllMain(HINSTANCE hInstDLL, DWORD fdwReason, LPVOID lpv)
> >  {
> >      switch(fdwReason)
> >      {
> > -
> >    case DLL_WINE_PREATTACH:
> > -
> >        return FALSE;  /* prefer native version */
>
> This is minor, but I don’t think we should prefer the builtin hid.dll until we’re done implementing it.

There's no such thing as a dll being done ;-)

It's OK to change it as soon as the dll starts doing something
useful. It should be a separate patch though.