Re: [PATCH] bcrypt/tests: Show that BCryptGetFipsAlgorithmMode checks a registry key

[Sebastian Lackner]

On 08.09.2016 22:11, Bruno Jesus wrote:
> - if (!RegOpenKeyW(HKEY_LOCAL_MACHINE, policyKeyVistaW, &hkey))
> - {

Why do you open the key when you don't use it?
> -
>    if (!RegGetValueW(HKEY_LOCAL_MACHINE, policyKeyVistaW, policyValueVistaW,
> -
>        RRF_RT_REG_DWORD, NULL, &enabled, &count))

enabled has the type BOOLEAN and a size of 1 byte. Did you want to pass "value" instead?
> -
>    {
> -
>        expected = !!enabled;
> -
>    }
> -
>    RegCloseKey(hkey);
> - }