Re: taskmodal messagebox implementation, take 3

[Ivan Leo Puoti]

> No problem.  I'll give a lengthy reply in the hope it can help other folks
> dealing with this sort of thing too.

Well, your code works, and I've made it into a patch. I've also removed
what I beleive is a useless if check from MSGBOX_OnInit().
Due to my lame webmail client you code arrived with no indentation, so in the
future please attach any code you send to me.
If you think the attached patch is OK I'll forward it to wine-patches.

Ivan.

____________________________________________________________
Libero ADSL: navighi gratis a 1.2 Mega, senza canone e costi di attivazione. 
Abbonati subito su http://www.libero.it

taskmodal messagebox implementation, take 3

[Juan Lang]

--- Ivan Leo Puoti  wrote:
> Well, your code works, and I've made it into a patch.

Cool.
> Due to my lame webmail client you code arrived with no indentation, so
> in the future please attach any code you send to me.

D'oh.  Okay.
> If you think the attached patch is OK I'll forward it to wine-patches.

A few minor points:
> - /*habdle modal message boxes*/

I missed that misspelling last time (handle, not habdle.)
> - if (!(hRes = FindResourceExW(user32_module, (LPWSTR)RT_DIALOG,
>
> msg_box_res_nameW, msgbox->dwLanguageId)))

This looks like a pretty long line, please wrap it.
> -
>    EnumThreadWindows(GetCurrentThreadId(),
>
> MSGBOX_CountDisabledThreadWindows, (LPARAM)&threadWindows.numHandles);

Ditto.
> -
>         threadWindows.handles = (HWND
>
> *)HeapAlloc(GetProcessHeap(), 0, threadWindows.numHandles *
> sizeof(HWND));

Ditto.
> -
>    EnumThreadWindows(GetCurrentThreadId(),
>
> MSGBOX_EnumDisabledThreadWindows, (LPARAM)&threadWindows);

Same here.
> - ret=DialogBoxIndirectParamW(msgbox->hInstance, tmplate,
>
> msgbox->hwndOwner, MSGBOX_DlgProc, (LPARAM)msgbox);

And here.

Thanks,
--Juan

__________________________________ 
Do you Yahoo!? 
Check out the new Yahoo! Front Page. 
www.yahoo.com