Re: edit control

[Robert Shearman]

Ulrich Czekalla wrote:
> ChangeLog:
>        Ulrich Czekalla 
>        Allow copying selection when control is read only
> Index: dlls/user/edit.c
>
> RCS file: /home/wine/wine/dlls/user/edit.c,v
> retrieving revision 1.1
> diff -u -r1.1 edit.c
> --- dlls/user/edit.c	31 Aug 2004 01:10:08 -0000	1.1
> +++ dlls/user/edit.c	9 Sep 2004 13:01:26 -0000
> @@ -3604,7 +3604,8 @@
>
> /* Protect read-only edit control from modification */
>    if(es->style & ES_READONLY)
> -
>    return;
> -
>        if (c != 0x03) /* Allow copying selection */
> -
>        return;
>
> control = GetKeyState(VK_CONTROL) & 0x8000;

That read-only check looks completely bogus to me as the code below 
already checks for ES_READONLY.

Rob

edit control

[Ulrich Czekalla]

Yeah, not all of it does. This cleans it up.

Thanks,

/Ulrich

On Thu, Sep 09, 2004 at 02:39:13PM +0100, Robert Shearman wrote:
> That read-only check looks completely bogus to me as the code below 
> already checks for ES_READONLY.