X11DRV_AlphaBlend: FIXME not a DIB section

[Damian Dixon]

Hi,

I'm trying to get an application running as best as possible under Wine and
have found that X11DRV_AlphaBlend does not handle Bitmaps which are not a
DIB Section.

I have also found that a number of people have submitted some fixes to
X11DRV_AlphaBlend:

1.
http://www.nabble.com/(re-resend)-x11drv%3A-implement-X11DRV_AlphaBlend-for-...
2. http://archives.free.net.ph/message/20080602.110501.ba1ea794.el.html

Is there a reason for these not being accepted?

I have started doing my own patch but wish to ensure the maximium liklyhood
of the patch being accepted.

I am taking a slightly different approach of trying to convert the Bitmap
into a DIB Section first, which would hopefully minimise any changes.

Does any one have any advice on how to approach this fix?

Thanks
Damian

[Aric Stewart]

Hi there,

As the author of one of the patches that was not approved,  Alexandre 
told me that he felt that the whole X11DRV_AlphaBlend needed to be 
rewritten, maybe not even found in that module.  If i recall correctly 
there was worries about how it was starting to duplicate code from the 
DIB drawing functions.

-aric

Damian Dixon wrote:
> Hi,
>
> I'm trying to get an application running as best as possible under Wine 
> and have found that X11DRV_AlphaBlend does not handle Bitmaps which are 
> not a DIB Section.
>
> I have also found that a number of people have submitted some fixes to 
> X11DRV_AlphaBlend:
> -
>
> http://www.nabble.com/(re-resend)-x11drv%3A-implement-X11DRV_AlphaBlend-for-...
> 2. http://archives.free.net.ph/message/20080602.110501.ba1ea794.el.html
>
> Is there a reason for these not being accepted?
>
> I have started doing my own patch but wish to ensure the maximium 
> liklyhood of the patch being accepted.
>
> I am taking a slightly different approach of trying to convert the 
> Bitmap into a DIB Section first, which would hopefully minimise any changes.
>
> Does any one have any advice on how to approach this fix?
>
> Thanks
> Damian