[PATCH] server: Move the \BaseNamedObjects symlink from \Sessions\0 to \Sessions\1\BaseNamedObjects.

[flan]

What is wrong with the patch? Right now the most glaring formatting
issue I can find is inconsistent spacing in a variable declaration, but
I'm asking just in case there are more problems I haven't noticed.

[Alex Henrie]

Hi Flan,

Thanks for your interest in contributing to Wine. The Wine project
requires you to use your real name (both first and last name) when
submitting patches. It might also be a good idea to contact Sebastian
Lackner, who is listed as a maintainer of this part of Wine. He might
be able to give you more specific feedback, or he might decide to
include your patch in Wine Staging to test it with a wider audience.

-Alex

[Sebastian Lackner]

On 07.07.2016 23:59, Alex Henrie wrote:
> Hi Flan,
>
> Thanks for your interest in contributing to Wine. The Wine project
> requires you to use your real name (both first and last name) when
> submitting patches. It might also be a good idea to contact Sebastian
> Lackner, who is listed as a maintainer of this part of Wine. He might
> be able to give you more specific feedback, or he might decide to
> include your patch in Wine Staging to test it with a wider audience.
>
> -Alex

I'm not the maintainer of this component, but Alex is right that you
will have to use your real name (both as author and also in the
Signed-off-by message).

I also believe that the variable names link_bno1W and link_bno1_str
are chosen a bit badly. The 1 does not really make any sense, and instead
of "bno" it might be better to use the same abbreviation "basenamed" as
above. If you make any changes, please also adjust the whitespace
inbetween of the variable name and "=" to match the surrounding code.

If \Sessions\1 contains all the elements from \, you could also
think about symlinking it to root (instead of symlinking each component
separately).

Regards,
Sebastian

[Alex Henrie]

2016-07-07 17:17 GMT-06:00 Sebastian Lackner :
> I'm not the maintainer of this component

MAINTAINERS seems to say that you're in charge of everything under
server/ - if that's not the case, it should be updated to be more
specific.

Thanks for giving Flan some suggestions.

-Alex

[Sebastian Lackner]

On 08.07.2016 01:29, Alex Henrie wrote:
> 2016-07-07 17:17 GMT-06:00 Sebastian Lackner :
> > I'm not the maintainer of this component
>
> MAINTAINERS seems to say that you're in charge of everything under
> server/ - if that's not the case, it should be updated to be more
> specific.

I fear you are mixing up the meaning of M and P. ;)

M: Primary maintainer. CC patches to: FullName 
P: Other knowledgeable person. FullName
> Thanks for giving Flan some suggestions.
>
> -Alex

[Alex Henrie]

2016-07-07 17:31 GMT-06:00 Sebastian Lackner :
> On 08.07.2016 01:29, Alex Henrie wrote:
> > 2016-07-07 17:17 GMT-06:00 Sebastian Lackner :
> > > I'm not the maintainer of this component
> >
> > MAINTAINERS seems to say that you're in charge of everything under
> > server/ - if that's not the case, it should be updated to be more
> > specific.
>
> I fear you are mixing up the meaning of M and P. ;)
>
> M: Primary maintainer. CC patches to: FullName 
> P: Other knowledgeable person. FullName

You're right, sorry. I'll pay more attention to that in the future.

-Alex

[flan]

On Fri, Jul 08, 2016 at 01:17:01AM +0200, Sebastian Lackner wrote:
> I'm not the maintainer of this component, but Alex is right that you
> will have to use your real name (both as author and also in the
> Signed-off-by message).
>
> I also believe that the variable names link_bno1W and link_bno1_str
> are chosen a bit badly. The 1 does not really make any sense, and instead
> of "bno" it might be better to use the same abbreviation "basenamed" as
> above. If you make any changes, please also adjust the whitespace
> inbetween of the variable name and "=" to match the surrounding code.
>
> If \Sessions\1 contains all the elements from \, you could also
> think about symlinking it to root (instead of symlinking each component
> separately).
>
> Regards,
> Sebastian

Thank you for the feedback, I'll change variable names and adjust the
whitespace. \Sessions\1 does not seem to contain all elements from \. The
only element besides BaseNamedObjects that's both in \ and \Sessions\1
seems to be \Windows and its child directory, WindowStations.

Is there any particular reason behind the real name requirement?

[Sebastian Lackner]

On 08.07.2016 03:05, flan wrote:
> On Fri, Jul 08, 2016 at 01:17:01AM +0200, Sebastian Lackner wrote:
> > I'm not the maintainer of this component, but Alex is right that you
> > will have to use your real name (both as author and also in the
> > Signed-off-by message).
> >
> > I also believe that the variable names link_bno1W and link_bno1_str
> > are chosen a bit badly. The 1 does not really make any sense, and instead
> > of "bno" it might be better to use the same abbreviation "basenamed" as
> > above. If you make any changes, please also adjust the whitespace
> > inbetween of the variable name and "=" to match the surrounding code.
> >
> > If \Sessions\1 contains all the elements from \, you could also
> > think about symlinking it to root (instead of symlinking each component
> > separately).
> >
> > Regards,
> > Sebastian
>
> Thank you for the feedback, I'll change variable names and adjust the
> whitespace. \Sessions\1 does not seem to contain all elements from \. The
> only element besides BaseNamedObjects that's both in \ and \Sessions\1
> seems to be \Windows and its child directory, WindowStations.

Okay, then the current approach should be fine.
> Is there any particular reason behind the real name requirement?

For the Wine project it is very important to make sure that all developers
are trustworthy and that they do not violate any laws, for example by
disassembling or looking at original Microsoft code. You can find more about
the requirements and guidelines on the following pages:

https://wiki.winehq.org/Submitting_Patches
https://wiki.winehq.org/Clean_Room_Guidelines

Although your patch is just a simple fix, for reasons of simplicity the rules
are the same for all kind of submissions.