Re: PATCH: winspool ordinal export

[Robert Shearman]

Hi Marcus,

Thanks for submitting a patch for this. I also have an application that 
depends on one of the exports to have a specific ordinal (203 - 
GetDefaultPrinterW).

Marcus Meissner wrote:
> -100 stub @
> +100 stub EnumPrinterPropertySheets@16

This should be --noname.
> +# 101 ClusterSplOpen@20
> +# 102 ClusterSplClose@4
> +# 103 ClusterSplIsAlive@4
> +201 stdcall GetDefaultPrinterA(ptr ptr)
> +# 202 _SetDefaultPrinterA@4
> +203 stdcall GetDefaultPrinterW(ptr ptr)
> +# 204 _SetDefaultPrinterW@4
> +# 205 _SplReadPrinter@12
> +# 206 _AddPerMachineConnectionA@16
> +# 207 _AddPerMachineConnectionW@16
> +# 208 _DeletePerMachineConnectionA@8
> +# 209 _DeletePerMachineConnectionW@8
> +# 210 _EnumPerMachineConnectionsA@20
> +# 211 _EnumPerMachineConnectionsW@20
> +# 212 _LoadPrinterDriver@4
> +# 213 _RefCntLoadDriver@16
> +# 214 _RefCntUnloadDriver@8
> +# 215 _ForceUnloadDriver@4
> +# 216 _PublishPrinterA@24
> +# 217 _PublishPrinterW@24
> +# 218 _CallCommonPropertySheetUI@16
> +# 219 _PrintUIQueueCreate@16
> +# 220 _PrintUIPrinterPropPages@16
> +# 221 _PrintUIDocumentDefaults@16
> +# 222 _SendRecvBidiData@16
> +# 223 _RouterFreeBidiResponseContainer@4
> +# 224 _ExternalConnectToLd64In32Server@4
> +# 226 _PrintUIWebPnpEntry@4
> +# 227 _PrintUIWebPnpPostEntry@16
> +# 228 _PrintUICreateInstance@8
> +# 229 _PrintUIDocumentPropertiesWrap@28
> +# 230 _PrintUIPrinterSetup@24
> +# 231 _PrintUIServerPropPages@16
> +# 232 _AddDriverCatalog@16
> -

We should add this ordinals, not just comment them out. Why? Because 
they are exported by ordinal only and so if an application (or more 
likely a Microsoft DLL) tries to use one of them it will end up with the 
wrong function, rather than just failing to import it and most likely 
will result in stack corruption. All of these should also be exported 
with --noname as they are ordinal-only exports.
> @ stub ADVANCEDSETUPDIALOG
> @ stdcall AbortPrinter(long)
> @ stdcall AddFormA(long long ptr)
> @@ -89,8 +124,6 @@
> @ stdcall FindFirstPrinterChangeNotification(long long long ptr)
> @ stdcall FindNextPrinterChangeNotification(long ptr ptr ptr)
> @ stdcall FreePrinterNotifyInfo(ptr)
> -@ stdcall GetDefaultPrinterA(ptr ptr)
> -@ stdcall GetDefaultPrinterW(ptr ptr)
> @ stdcall GetFormA(long str long ptr long ptr)
> @ stdcall GetFormW(long wstr long ptr long ptr)
> @ stdcall GetJobA(long long long ptr long ptr)