Recently created font problem - anyone see similar?

[Dr J A Gow]

Hi,

I found that the following patch, committed to CVS on 23/02/06
at 20:33:06 made all my Wine system fonts squashed up and unreadable, which
in turn made a mess of formatting in some dialog boxes. I backed the
patch out from a current tree and the problem went away. Anyone else see
this behaviour? I am wondering what the purpose of this patch is as
the fonts were quite OK before it was committed, and now they are
completely unreadable on this system. Any thoughts before I submit a
patch to put this back the way it was?

John.

The offending patch:

Module: wine
Branch: refs/heads/master
Commit: 69a23a608eea59624b2f37ab424e0f42b3da5baf
URL:    http://source.winehq.org/git/?p=wine.git;a=commit;h=69a23a608eea59624b2f37ab...

Author: Dmitry Timoshkov <dmitry at codeweavers.com>
Date:   Thu Feb 23 20:33:06 2006 +0800

gdi: Use "MS Sans Serif" as default sans serif font, not Arial.

---

dlls/gdi/freetype.c |    4 ++--
  1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/dlls/gdi/freetype.c b/dlls/gdi/freetype.c
index ad0d6eb..51e92b8 100644
--- a/dlls/gdi/freetype.c
+++ b/dlls/gdi/freetype.c
@@ -284,10 +284,10 @@ static struct list font_list = LIST_INIT

static const WCHAR defSerif[] = {'T','i','m','e','s',' ','N','e','w',' ',
    		   'R','o','m','a','n','\0'};
-static const WCHAR defSans[] = {'A','r','i','a','l','\0'};
+static const WCHAR defSans[] = {'M','S',' ','S','a','n','s',' ','S','e','r','i','f','\0'};
  static const WCHAR defFixed[] = {'C','o','u','r','i','e','r',' ','N','e','w','\0'};

-static const WCHAR defSystem[] = {'A','r','i','a','l','\0'};
+static const WCHAR defSystem[] = {'S','y','s','t','e','m','\0'};
  static const WCHAR SystemW[] = {'S','y','s','t','e','m','\0'};
  static const WCHAR MSSansSerifW[] = {'M','S',' ','S','a','n','s',' ',
    		       'S','e','r','i','f','\0'};

[Andrew Z]

Dr J A Gow <J.A.Gow <at> furrybubble.co.uk> writes:
> I found that the following patch, committed to CVS on 23/02/06
> at 20:33:06 made all my Wine system fonts squashed up and unreadable, which
> in turn made a mess of formatting in some dialog boxes. I backed the
> patch out from a current tree and the problem went away. Anyone else see
> this behaviour? I am wondering what the purpose of this patch is as
> the fonts were quite OK before it was committed, and now they are
> completely unreadable on this system. Any thoughts before I submit a
> patch to put this back the way it was?

I had this problem too:
http://bugs.winehq.org/show_bug.cgi?id=4682

I like the old behavior, and I don't like the solution of copying the fonts to
the /usr/share/fonts because I want to be able to build WINE from source and run
it from ~/wine without root permission (to install the fonts).

Andrew

[Dmitry Timoshkov]

"Dr J A Gow"  wrote:
> I found that the following patch, committed to CVS on 23/02/06
> at 20:33:06 made all my Wine system fonts squashed up and unreadable, which
> in turn made a mess of formatting in some dialog boxes. I backed the
> patch out from a current tree and the problem went away. Anyone else see
> this behaviour? I am wondering what the purpose of this patch is as
> the fonts were quite OK before it was committed, and now they are
> completely unreadable on this system. Any thoughts before I submit a
> patch to put this back the way it was?

This usially means that you have no Wine bitmap fonts installed in windows/fonts.
I sent a patch to wineprefixcreate to install them by default, by Alexandre
rejected it.

[Joris Huizer]

Dr J A Gow wrote:
> Hi,
> I found that the following patch, committed to CVS on 23/02/06
>
> at 20:33:06 made all my Wine system fonts squashed up and unreadable, which
> in turn made a mess of formatting in some dialog boxes. I backed the
> patch out from a current tree and the problem went away. Anyone else see
> this behaviour? I am wondering what the purpose of this patch is as
> the fonts were quite OK before it was committed, and now they are
> completely unreadable on this system. Any thoughts before I submit a
> patch to put this back the way it was?
> John.
>
> The offending patch:
>
> Module: wine
> Branch: refs/heads/master
> Commit: 69a23a608eea59624b2f37ab424e0f42b3da5baf
> URL:    
> http://source.winehq.org/git/?p=wine.git;a=commit;h=69a23a608eea59624b2f37ab...
>
> Author: Dmitry Timoshkov <dmitry at codeweavers.com>
> Date:   Thu Feb 23 20:33:06 2006 +0800
>
> gdi: Use "MS Sans Serif" as default sans serif font, not Arial.
>
> dlls/gdi/freetype.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/dlls/gdi/freetype.c b/dlls/gdi/freetype.c
> index ad0d6eb..51e92b8 100644
> --- a/dlls/gdi/freetype.c
> +++ b/dlls/gdi/freetype.c
> @@ -284,10 +284,10 @@ static struct list font_list = LIST_INIT
>
> static const WCHAR defSerif[] = {'T','i','m','e','s',' ','N','e','w',' ',
>                 'R','o','m','a','n','\0'};
> -static const WCHAR defSans[] = {'A','r','i','a','l','\0'};
> +static const WCHAR defSans[] = {'M','S',' ','S','a','n','s',' 
> ','S','e','r','i','f','\0'};
>  static const WCHAR defFixed[] = {'C','o','u','r','i','e','r',' 
> ','N','e','w','\0'};
>
> -static const WCHAR defSystem[] = {'A','r','i','a','l','\0'};
> +static const WCHAR defSystem[] = {'S','y','s','t','e','m','\0'};
>  static const WCHAR SystemW[] = {'S','y','s','t','e','m','\0'};
>  static const WCHAR MSSansSerifW[] = {'M','S',' ','S','a','n','s',' ',
>                     'S','e','r','i','f','\0'};

I the same font problem (I think) - In firefox, everything shows ok but 
file-saving dialogs (and maybe more?) render blocks instead of letters; 
where should I find the fonts wine used before, and where are they 
placed? (it seems ~/.wine/drive_c/windows/fonts is the directory that is 
mentioned?)

thanks,

Joris