On Wed, Mar 02, 2016 at 08:51:49AM +0100, Sebastian Lackner wrote:
From: Michael Müller michael@fds-team.de
Signed-off-by: Michael Müller michael@fds-team.de Signed-off-by: Sebastian Lackner sebastian@fds-team.de
Changes in v2 (thanks Nikolay):
- Replace ERROR_SUCCESS -> S_OK (Oopps..)
- Initialize variables in tests to make it more convincing.
dlls/api-ms-win-core-com-l1-1-0/api-ms-win-core-com-l1-1-0.spec | 2 dlls/api-ms-win-core-com-l1-1-1/api-ms-win-core-com-l1-1-1.spec | 2 dlls/api-ms-win-downlevel-ole32-l1-1-0/api-ms-win-downlevel-ole32-l1-1-0.spec | 2 dlls/combase/combase.spec | 2 dlls/ole32/compobj.c | 29 +++++ dlls/ole32/ole32.spec | 1 dlls/ole32/tests/compobj.c | 56 ++++++++++ include/objidl.idl | 9 + 8 files changed, 99 insertions(+), 4 deletions(-)
The prototype should go in objbase.h .
Actually, newer SDKs have moved that into combaseapi.h, but we don't have that yet so objbase.h is good for now.
Huw.
On 02.03.2016 10:20, Huw Davies wrote:
On Wed, Mar 02, 2016 at 08:51:49AM +0100, Sebastian Lackner wrote:
From: Michael Müller michael@fds-team.de
Signed-off-by: Michael Müller michael@fds-team.de Signed-off-by: Sebastian Lackner sebastian@fds-team.de
Changes in v2 (thanks Nikolay):
- Replace ERROR_SUCCESS -> S_OK (Oopps..)
- Initialize variables in tests to make it more convincing.
dlls/api-ms-win-core-com-l1-1-0/api-ms-win-core-com-l1-1-0.spec | 2 dlls/api-ms-win-core-com-l1-1-1/api-ms-win-core-com-l1-1-1.spec | 2 dlls/api-ms-win-downlevel-ole32-l1-1-0/api-ms-win-downlevel-ole32-l1-1-0.spec | 2 dlls/combase/combase.spec | 2 dlls/ole32/compobj.c | 29 +++++ dlls/ole32/ole32.spec | 1 dlls/ole32/tests/compobj.c | 56 ++++++++++ include/objidl.idl | 9 + 8 files changed, 99 insertions(+), 4 deletions(-)
The prototype should go in objbase.h .
Actually, newer SDKs have moved that into combaseapi.h, but we don't have that yet so objbase.h is good for now.
Huw.
Are you sure? In my Windows 10 header files, its defined in ObjIdl.h and ObjIdlbase.h, but not in combaseapi.h. This is also what MSDN says. Should I move it nevertheless?
On 02.03.2016 17:41, Sebastian Lackner wrote:
On 02.03.2016 10:20, Huw Davies wrote:
On Wed, Mar 02, 2016 at 08:51:49AM +0100, Sebastian Lackner wrote:
From: Michael Müller michael@fds-team.de
Signed-off-by: Michael Müller michael@fds-team.de Signed-off-by: Sebastian Lackner sebastian@fds-team.de
Changes in v2 (thanks Nikolay):
- Replace ERROR_SUCCESS -> S_OK (Oopps..)
- Initialize variables in tests to make it more convincing.
dlls/api-ms-win-core-com-l1-1-0/api-ms-win-core-com-l1-1-0.spec | 2 dlls/api-ms-win-core-com-l1-1-1/api-ms-win-core-com-l1-1-1.spec | 2 dlls/api-ms-win-downlevel-ole32-l1-1-0/api-ms-win-downlevel-ole32-l1-1-0.spec | 2 dlls/combase/combase.spec | 2 dlls/ole32/compobj.c | 29 +++++ dlls/ole32/ole32.spec | 1 dlls/ole32/tests/compobj.c | 56 ++++++++++ include/objidl.idl | 9 + 8 files changed, 99 insertions(+), 4 deletions(-)
The prototype should go in objbase.h .
Actually, newer SDKs have moved that into combaseapi.h, but we don't have that yet so objbase.h is good for now.
Huw.
Are you sure? In my Windows 10 header files, its defined in ObjIdl.h and ObjIdlbase.h, but not in combaseapi.h. This is also what MSDN says. Should I move it nevertheless?
In SDK 10.0.10240.0 it's only defined in combaseapi.h. Yours is newer?
On 02.03.2016 15:57, Nikolay Sivov wrote:
On 02.03.2016 17:41, Sebastian Lackner wrote:
On 02.03.2016 10:20, Huw Davies wrote:
On Wed, Mar 02, 2016 at 08:51:49AM +0100, Sebastian Lackner wrote:
From: Michael Müller michael@fds-team.de
Signed-off-by: Michael Müller michael@fds-team.de Signed-off-by: Sebastian Lackner sebastian@fds-team.de
Changes in v2 (thanks Nikolay):
- Replace ERROR_SUCCESS -> S_OK (Oopps..)
- Initialize variables in tests to make it more convincing.
dlls/api-ms-win-core-com-l1-1-0/api-ms-win-core-com-l1-1-0.spec | 2 dlls/api-ms-win-core-com-l1-1-1/api-ms-win-core-com-l1-1-1.spec | 2 dlls/api-ms-win-downlevel-ole32-l1-1-0/api-ms-win-downlevel-ole32-l1-1-0.spec | 2 dlls/combase/combase.spec | 2 dlls/ole32/compobj.c | 29 +++++ dlls/ole32/ole32.spec | 1 dlls/ole32/tests/compobj.c | 56 ++++++++++ include/objidl.idl | 9 + 8 files changed, 99 insertions(+), 4 deletions(-)
The prototype should go in objbase.h .
Actually, newer SDKs have moved that into combaseapi.h, but we don't have that yet so objbase.h is good for now.
Huw.
Are you sure? In my Windows 10 header files, its defined in ObjIdl.h and ObjIdlbase.h, but not in combaseapi.h. This is also what MSDN says. Should I move it nevertheless?
In SDK 10.0.10240.0 it's only defined in combaseapi.h. Yours is newer?
My version is 10.0.10586.0.
On Wed, Mar 02, 2016 at 03:41:55PM +0100, Sebastian Lackner wrote:
On 02.03.2016 10:20, Huw Davies wrote:
The prototype should go in objbase.h .
Actually, newer SDKs have moved that into combaseapi.h, but we don't have that yet so objbase.h is good for now.
Are you sure? In my Windows 10 header files, its defined in ObjIdl.h and ObjIdlbase.h, but not in combaseapi.h. This is also what MSDN says. Should I move it nevertheless?
I'm talking about the function prototype which was missing from the patch. For Windows 7 is was objbase.h, for Windows 8 it was combaseapi.h, did it move again for Windows 10?
Huw.
On 02.03.2016 16:01, Huw Davies wrote:
On Wed, Mar 02, 2016 at 03:41:55PM +0100, Sebastian Lackner wrote:
On 02.03.2016 10:20, Huw Davies wrote:
The prototype should go in objbase.h .
Actually, newer SDKs have moved that into combaseapi.h, but we don't have that yet so objbase.h is good for now.
Are you sure? In my Windows 10 header files, its defined in ObjIdl.h and ObjIdlbase.h, but not in combaseapi.h. This is also what MSDN says. Should I move it nevertheless?
I'm talking about the function prototype which was missing from the patch. For Windows 7 is was objbase.h, for Windows 8 it was combaseapi.h, did it move again for Windows 10?
Huw.
Ah, sorry, I was assuming you talk about the enum because there were no prototype definitions in the patch. Will send a new version.
-
Huw Davies -
Nikolay Sivov -
Sebastian Lackner