Re: [PATCH 3/6] dinput: SetActionMap setting the device buffer (try 2)

[Alexandre Julliard]

Lucas Fialho Zawacki  writes:
> - FIXME("(%p)->(%p,%s,%08x): semi-stub !\n", iface, lpdiaf, lpszUserName, dwFlags);
> -
> - diafW.rgoAction = HeapAlloc(GetProcessHeap(), 0, sizeof(DIACTIONW)*lpdiaf->dwNumActions);
> - _copy_diactionformatAtoW(&diafW, lpdiaf);
> -
> - hr = IDirectInputDevice8WImpl_SetActionMap(&This->IDirectInputDevice8W_iface, &diafW, NULL, dwFlags);
> -
> - _copy_diactionformatWtoA(lpdiaf, &diafW);

Do you really need to copy it back?  It looks like an input parameter.

[PATCH 3/6] dinput: SetActionMap setting the device buffer (try 2)

[Lucas Zawacki]

> Do you really need to copy it back?  It looks like an input parameter.

Yes, you're right. In SetActionMap this copy should not be necessary.
I'll take this code out and roll a new version of the patches.

[PATCH 3/6] dinput: SetActionMap setting the device buffer (try 2)

[Lucas Zawacki]

The new patches address this issue, make some little corrections that
are pointed in the comments. Also I organized them better, with the
tests first.

2011/6/28 Lucas Zawacki :
> > Do you really need to copy it back?  It looks like an input parameter.
>
> Yes, you're right. In SetActionMap this copy should not be necessary.
> I'll take this code out and roll a new version of the patches.