Re: CreateDIBitmap fix

[Stefan Leichter]

Am Montag, 13. September 2004 13:12 schrieb Huw D M Davies:
>     Michael Kaufmann <[e-mail]>
>     Huw Davies <[e-mail]>
>     CreateDIBitmap should return bitmaps at the depth of the
>     supplied dc.
>     Add a test to exercise this behaviour.

Hello,

this patch broke my Freecell (the version shiped with the win32s extension). 
When starting the game i am get now these fixme's:

fixme:bitmap:CreateCompatibleBitmap got bad width 6291527 or height 65537, 
please look for reason

Grepping the logfile i found the values first in a call of CreateBitmap, but i 
have no idea where the values are created. I noticed that the lower word of 
the width is correct.

Does anyone have a clue how to debug / fix this ?

Bye Stefan

CreateDIBitmap fix

[Huw D M Davies]

On Sun, Sep 19, 2004 at 12:03:36AM +0200, Stefan Leichter wrote:
> fixme:bitmap:CreateCompatibleBitmap got bad width 6291527 or height 65537, 
> please look for reason
>
> Grepping the logfile i found the values first in a call of CreateBitmap, but i 
> have no idea where the values are created. I noticed that the lower word of 
> the width is correct.
>
> Does anyone have a clue how to debug / fix this ?

Could you send me a +relay,+bitmap log?

Thanks,
Huw.

CreateDIBitmap fix

[Michael Kaufmann]

Hi,

I've found the bug and fixed it: 
http://www.winehq.org/hypermail/wine-patches/2004/09/0341.html
It's indeed a regression caused by the CreateDIBitmap patch. Even 
Solitaire has been broken - sorry!

The function LoadBitmap was not able to load a bitmap with a 
BITMAPCOREHEADER. Most bitmaps have a BITMAPINFOHEADER.
Unfortunately, I had to duplicate an internal function 
(DIB_GetBitmapInfo) in my new patch.

Regards

Michael
> Am Montag, 13. September 2004 13:12 schrieb Huw D M Davies:
> >    Michael Kaufmann <[e-mail]>
> >    Huw Davies <[e-mail]>
> >    CreateDIBitmap should return bitmaps at the depth of the
> >    supplied dc.
> >    Add a test to exercise this behaviour.
>
> Hello,
>
> this patch broke my Freecell (the version shiped with the win32s extension). 
> When starting the game i am get now these fixme's:
>
> fixme:bitmap:CreateCompatibleBitmap got bad width 6291527 or height 65537, 
> please look for reason
>
> Grepping the logfile i found the values first in a call of CreateBitmap, but i 
> have no idea where the values are created. I noticed that the lower word of 
> the width is correct.
>
> Does anyone have a clue how to debug / fix this ?
>
> Bye Stefan

CreateDIBitmap fix

[Stefan Leichter]

Many thanks

your patch fixes my problem

Stefan

Am Sonntag, 19. September 2004 16:52 schrieb Michael Kaufmann:
> Hi,
>
> I've found the bug and fixed it:
> http://www.winehq.org/hypermail/wine-patches/2004/09/0341.html
> It's indeed a regression caused by the CreateDIBitmap patch. Even
> Solitaire has been broken - sorry!
>
> The function LoadBitmap was not able to load a bitmap with a
> BITMAPCOREHEADER. Most bitmaps have a BITMAPINFOHEADER.
> Unfortunately, I had to duplicate an internal function
> (DIB_GetBitmapInfo) in my new patch.
>
> Regards
>
> Michael
> > Am Montag, 13. September 2004 13:12 schrieb Huw D M Davies:
> > >    Michael Kaufmann <[e-mail]>
> > >    Huw Davies <[e-mail]>
> > >    CreateDIBitmap should return bitmaps at the depth of the
> > >    supplied dc.
> > >    Add a test to exercise this behaviour.
> >
> > Hello,
> >
> > this patch broke my Freecell (the version shiped with the win32s
> > extension). When starting the game i am get now these fixme's:
> >
> > fixme:bitmap:CreateCompatibleBitmap got bad width 6291527 or height 65537,
> > please look for reason
> >
> > Grepping the logfile i found the values first in a call of CreateBitmap,
> > but i have no idea where the values are created. I noticed that the lower
> > word of the width is correct.
> >
> > Does anyone have a clue how to debug / fix this ?
> >
> > Bye Stefan