Re: [PATCH 1/3] riched20: Use codepage in ME_ToUnicode. (try 2)

[Nikolay Sivov]

On 9/4/2013 07:17, Jactry Zeng wrote:
> -
>    ME_EndToUnicode(unicode, wszText);
> -
>    ME_EndToUnicode(unicode ? 1200 : CP_ACP, wszText);

It's still ugly to use magic numbers like that, in a similar situation I 
had some time
ago I use ~0 to mark WCHAR data encoding that does need special handling.
Even with a value like ~0 it needs to be documented in code comments.

[PATCH 1/3] riched20: Use codepage in ME_ToUnicode. (try 2)

[Jactry Zeng]

Hi Nikolay,

2013/9/5 Nikolay Sivov
> On 9/4/2013 07:17, Jactry Zeng wrote:
> > -
> >    ME_EndToUnicode(unicode, wszText);
> > -
> >    ME_EndToUnicode(unicode ? 1200 : CP_ACP, wszText);
>
> It's still ugly to use magic numbers like that, in a similar situation I

had some time
> ago I use ~0 to mark WCHAR data encoding that does need special handling.
> Even with a value like ~0 it needs to be documented in code comments.

Thanks for your review!
But I still can't understand it. :(  Can you show me a commit as an example.

Thank you!

(sorry for forgeting cc wine-devel)
--
Regards,
Jactry Zeng

[PATCH 1/3] riched20: Use codepage in ME_ToUnicode. (try 2)

[Nikolay Sivov]

On 9/4/2013 21:16, Jactry Zeng wrote:
> Hi Nikolay,
>
> 2013/9/5 Nikolay Sivov <[e-mail] 
> >
> > On 9/4/2013 07:17, Jactry Zeng wrote:
> > > -
> > >    ME_EndToUnicode(unicode, wszText);
> > > -
> > >    ME_EndToUnicode(unicode ? 1200 : CP_ACP, wszText);
> >
> > It's still ugly to use magic numbers like that, in a similar
>
> situation I had some time
> > ago I use ~0 to mark WCHAR data encoding that does need special
>
> handling.
> > Even with a value like ~0 it needs to be documented in code comments.
>
> Thanks for your review!
> But I still can't understand it. :(  Can you show me a commit as an 
> example.

What I mean is it's better to use something more neutral to mark an 
absence of
codepage.

In my case it was like that 
http://source.winehq.org/git/wine.git/commit/320d419be1fe713c50eac7d53e4dc52...
> Thank you!
> (sorry for forgeting cc wine-devel)
>
> Regards,
> Jactry Zeng