Am 2017-02-17 um 06:05 schrieb Alex Henrie:
dlls/ddraw/tests/dsurface.c | 10 ++++++++++
The rule is to not add new things to these old files, even if it is a minor obvious fix. If you want to change a test in there move it to tests/ddraw*.c (changing the code style, using the existing helper functions in the file, test all versions etc) and implement the change there. See e.g. http://source.winehq.org/patches/data/130355 .
Yeah, it's a pesky work, but it needs to be done in the long run anyway.
2017-02-17 1:39 GMT-07:00 Stefan Dösinger stefandoesinger@gmail.com:
Am 2017-02-17 um 06:05 schrieb Alex Henrie:
dlls/ddraw/tests/dsurface.c | 10 ++++++++++
The rule is to not add new things to these old files, even if it is a minor obvious fix. If you want to change a test in there move it to tests/ddraw*.c (changing the code style, using the existing helper functions in the file, test all versions etc) and implement the change there. See e.g. http://source.winehq.org/patches/data/130355 .
Yeah, it's a pesky work, but it needs to be done in the long run anyway.
Unless it's really important to you, I'm not going to rewrite the dsurface tests. The game I was debugging is fixed now, it's unlikely to be broken again in the future, and I'd like to move on to other bugs.
-Alex
On 20 February 2017 at 07:59, Alex Henrie alexhenrie24@gmail.com wrote:
Unless it's really important to you, I'm not going to rewrite the dsurface tests. The game I was debugging is fixed now, it's unlikely to be broken again in the future, and I'd like to move on to other bugs.
That's fine, but I would have preferred you'd said that when I asked.
2017-02-17 1:39 GMT-07:00 Stefan Dösinger stefandoesinger@gmail.com:
Am 2017-02-17 um 06:05 schrieb Alex Henrie:
dlls/ddraw/tests/dsurface.c | 10 ++++++++++
The rule is to not add new things to these old files, even if it is a minor obvious fix. If you want to change a test in there move it to tests/ddraw*.c (changing the code style, using the existing helper functions in the file, test all versions etc) and implement the change there. See e.g. http://source.winehq.org/patches/data/130355 .
Yeah, it's a pesky work, but it needs to be done in the long run anyway.
2017-02-20 8:37 GMT-07:00 Henri Verbeet hverbeet@gmail.com:
On 20 February 2017 at 07:59, Alex Henrie alexhenrie24@gmail.com wrote:
Unless it's really important to you, I'm not going to rewrite the dsurface tests. The game I was debugging is fixed now, it's unlikely to be broken again in the future, and I'd like to move on to other bugs.
That's fine, but I would have preferred you'd said that when I asked.
I thought that you were asking for small changes (which I wrote and submitted) and Stefan was asking for big changes. I did not understand until just now that you had also been asking for big changes. A note in dsurface.c explaining this policy would be helpful, but at the very least, now that I know what the policy is I will submit better patches in the future.
-Alex
-
Alex Henrie -
Henri Verbeet -
Stefan Dösinger