Enabling gcov patch not accepted

[Aaron Arvey]

Hi,

I recently sent in a patch concerning enabling gcov in wine
(http://www.winehq.org/hypermail/wine-patches/2004/11/0136.html) and it
doesn't seem to have been incorporated in the main cvs branch :(.

I have never contributed to wine before so I'm not sure how to get
feedback on my patch in order to improve it so that it is accepted.  If
either Alexandre or anyone else believes they know why my patch wasn't
accepted, please let me know.

I personally have found gcov to be very helpful and I think other
developers may find that to be true too.  If you would like to know more
about gcov, please read the documentation included in my patch (url
above).

Thank you,

Aaron

[Jeremy White]

Hi Aaron,

Alexandre is not that fast in the very best of times
(your patch was submitted 2 days ago, and he can often take
a week or more to get to a patch).

Further, Alexandre is currently on an airplane to Switzerland
and will be out of reach for at least another 4 days.

However, he does not mind if folks bug him about dropped
patches; maybe give it another week and ask again.

Cheers,

Jeremy

Aaron Arvey wrote:
> Hi,
>
> I recently sent in a patch concerning enabling gcov in wine
> (http://www.winehq.org/hypermail/wine-patches/2004/11/0136.html) and it
> doesn't seem to have been incorporated in the main cvs branch :(.
>
> I have never contributed to wine before so I'm not sure how to get
> feedback on my patch in order to improve it so that it is accepted.  If
> either Alexandre or anyone else believes they know why my patch wasn't
> accepted, please let me know.
>
> I personally have found gcov to be very helpful and I think other
> developers may find that to be true too.  If you would like to know more
> about gcov, please read the documentation included in my patch (url
> above).
>
> Thank you,
>
> Aaron

[Dan Kegel]

Jeremy White wrote:
> > I recently sent in a patch concerning enabling gcov in wine
> > (http://www.winehq.org/hypermail/wine-patches/2004/11/0136.html) and it
> > doesn't seem to have been incorporated in the main cvs branch :(.
>
> Hi Aaron,
> Alexandre is not that fast in the very best of times
> (your patch was submitted 2 days ago, and he can often take
> a week or more to get to a patch).
>
> Further, Alexandre is currently on an airplane to Switzerland
> and will be out of reach for at least another 4 days.
>
> However, he does not mind if folks bug him about dropped
> patches; maybe give it another week and ask again.

Also, on many projects, it's fairly common for maintainers
to have very full and noisy inboxes, so one should expect
patches to take a while to make it through, and not
be surprised if you end up having to resend once or twice
(usually after waiting for the next snapshot to come out).
- Dan