Re: Changes to enable the use of gcov

[James McKenzie]

Peter Davies wrote:
> To use gcov you must pass --coverage at both compile and link time.
> This patch means that "make CFLAGS=--coverage LDFLAGS=--coverage", "make test",
> "gcov file.c" is sufficient generate .gcov files.

Peter:

Somehow this patch got munged in transit and will not apply to current 
git.  Can you update it and send it again?

James McKenzie

Changes to enable the use of gcov

[Scott Ritchie]

On 06/14/2010 08:04 PM, James McKenzie wrote:
> Peter Davies wrote:
> > To use gcov you must pass --coverage at both compile and link time.
> > This patch means that "make CFLAGS=--coverage LDFLAGS=--coverage",
> > "make test",
> > "gcov file.c" is sufficient generate .gcov files.
>
> Peter:
>
> Somehow this patch got munged in transit and will not apply to current
> git.  Can you update it and send it again?
>
> James McKenzie

As an aside, if gcov compilation finally starts working that means we
can build Wine using GCC's Profile Guided Optimization.  In other
applications this has made a very significant boost in performance, and
it's basically "free".

Thanks,
Scott Ritchie

Changes to enable the use of gcov

[Peter Davies]

> Somehow this patch got munged in transit and will not apply to current git.  Can you update it and send it again?

I think my mail client (gmail) line wraps. I discovered when trying to
apply it myself.
> As an aside, if gcov compilation finally starts working that means we
> can build Wine using GCC's Profile Guided Optimization.  In other
> applications this has made a very significant boost in performance, and
> it's basically "free".

The changes to enable gcov are trivial, all we have to do is have
winegcc let the relevent options through. I'll resend the patch and
make sure it helps with PGA.

Peter