This also fixes a failure in the 64-bit urlmon:misc.
Signed-off-by: Francois Gouget fgouget@codeweavers.com --- I figured that if .Net is mandatory we should check for it explicitly, which shows more clearly that it is missing for all versions. If we wanted the tests to pass without Wine-Mono that would be wrong but I don't think we want to run the tests in such a configuration.
dlls/urlmon/tests/misc.c | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/dlls/urlmon/tests/misc.c b/dlls/urlmon/tests/misc.c index 2b3df65d5fc..00de143a53c 100644 --- a/dlls/urlmon/tests/misc.c +++ b/dlls/urlmon/tests/misc.c @@ -1544,6 +1544,7 @@ static void test_user_agent(void) }else if(sizeof(void*) == 8) { p += check_prefix(p, "Win64; "); #ifdef __x86_64__ + todo_wine p += check_prefix(p, "x64; "); #endif } @@ -1556,15 +1557,19 @@ static void test_user_agent(void) } p++; /* skip version number */ p += check_prefix(p, ".0"); + if (*p == ';') + p += check_prefix(p, "; "); } if(i == 11) { - p += check_prefix(p, "; rv:11.0) like Gecko"); + p += check_prefix(p, "rv:11.0) like Gecko"); + }else if (i >= 9) { + p += check_prefix(p, ")"); }else { - if(i != 1) - ok(*p == ';' || *p == ')', "unexpected suffix %s for version %u\n", - wine_dbgstr_a(p), i); - if(i < 9) - p = strchr(p, ')'); +#ifdef __x86_64__ + todo_wine +#endif + p += check_prefix(p, ".NET"); + p = strchr(p, ')'); p += check_prefix(p, ")"); }
Hi,
While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check?
Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=89998
Your paranoid android.
=== w2008s64 (32 bit report) ===
urlmon: misc.c:1455: Test failed: no ".NET" prefix in "SLCC1; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; .NET4.0C; .NET4.0E)"
=== w7u_2qxl (32 bit report) ===
urlmon: misc.c:1455: Test failed: no ".NET" prefix in "SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; Media Center PC 6.0; .NET4.0C; .NET4.0E)" misc.c:1455: Test failed: no ".NET" prefix in "SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; Media Center PC 6.0; .NET4.0C; .NET4.0E)" misc.c:1455: Test failed: no ".NET" prefix in "SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; Media Center PC 6.0; .NET4.0C; .NET4.0E)" misc.c:1455: Test failed: no ".NET" prefix in "SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; Media Center PC 6.0; .NET4.0C; .NET4.0E)" misc.c:1455: Test failed: no ".NET" prefix in "SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; Media Center PC 6.0; .NET4.0C; .NET4.0E)" misc.c:1455: Test failed: no ".NET" prefix in "SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; Media Center PC 6.0; .NET4.0C; .NET4.0E)" misc.c:1455: Test failed: no ".NET" prefix in "SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; Media Center PC 6.0; .NET4.0C; .NET4.0E)" misc.c:1455: Test failed: no ".NET" prefix in "SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; Media Center PC 6.0; .NET4.0C; .NET4.0E)"
=== w7u_adm (32 bit report) ===
urlmon: misc.c:1455: Test failed: no ".NET" prefix in "SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; Media Center PC 6.0; .NET4.0C; .NET4.0E)" misc.c:1455: Test failed: no ".NET" prefix in "SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; Media Center PC 6.0; .NET4.0C; .NET4.0E)" misc.c:1455: Test failed: no ".NET" prefix in "SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; Media Center PC 6.0; .NET4.0C; .NET4.0E)" misc.c:1455: Test failed: no ".NET" prefix in "SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; Media Center PC 6.0; .NET4.0C; .NET4.0E)" misc.c:1455: Test failed: no ".NET" prefix in "SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; Media Center PC 6.0; .NET4.0C; .NET4.0E)" misc.c:1455: Test failed: no ".NET" prefix in "SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; Media Center PC 6.0; .NET4.0C; .NET4.0E)" misc.c:1455: Test failed: no ".NET" prefix in "SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; Media Center PC 6.0; .NET4.0C; .NET4.0E)" misc.c:1455: Test failed: no ".NET" prefix in "SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; Media Center PC 6.0; .NET4.0C; .NET4.0E)"
=== w7u_el (32 bit report) ===
urlmon: misc.c:1455: Test failed: no ".NET" prefix in "SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; Media Center PC 6.0; .NET4.0C; .NET4.0E)" misc.c:1455: Test failed: no ".NET" prefix in "SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; Media Center PC 6.0; .NET4.0C; .NET4.0E)" misc.c:1455: Test failed: no ".NET" prefix in "SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; Media Center PC 6.0; .NET4.0C; .NET4.0E)" misc.c:1455: Test failed: no ".NET" prefix in "SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; Media Center PC 6.0; .NET4.0C; .NET4.0E)" misc.c:1455: Test failed: no ".NET" prefix in "SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; Media Center PC 6.0; .NET4.0C; .NET4.0E)" misc.c:1455: Test failed: no ".NET" prefix in "SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; Media Center PC 6.0; .NET4.0C; .NET4.0E)" misc.c:1455: Test failed: no ".NET" prefix in "SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; Media Center PC 6.0; .NET4.0C; .NET4.0E)" misc.c:1455: Test failed: no ".NET" prefix in "SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; Media Center PC 6.0; .NET4.0C; .NET4.0E)"
On Thu, 6 May 2021, Marvin wrote: [...]
=== w7u_2qxl (32 bit report) ===
urlmon: misc.c:1455: Test failed: no ".NET" prefix in "SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; Media Center PC 6.0; .NET4.0C; .NET4.0E)"
Ok. So I'll send an updated version that works on Windows <= 7.