-----BEGIN PGP SIGNED MESSAGE-----
Moin,
[crosspost to both wine lists]
I am preparing a patch for DirectDraw::SetCooperativeLevel and friends:
Some questions from a newbie, so please bear with me:
ddraw/user.c has comments like these:
/* GetDisplayMode: generic */ /* GetFourCCCodes: generic */ /* GetGDISurface: ??? */ /* GetMonitorFrequency: generic */ /* GetScanLine: generic */ /* GetSurfaceFromDC: generic */ /* GetVerticalBlankStatus: generic */ /* Initialize: generic */ /* RestoreAllSurfaces: generic */ /* RestoreDisplayMode: generic */ /* SetCooperativeLevel: ??? */
* What does the "generic" stand for? Return value? Function class? * It seems that SetCooperativeLevel associates a "value" (or more than one) with the givenwindow handle and TestCooperativeLevel let's you later check this status. Where would I store such a "global" value? * If I understand it correctly, the directx stuff is done by transgaming. Their licence differs from the "normal" wine. (I am really unsure how all these things play together even after readin codeweavers.com, winehq.com and transgaming.com). So, if I send in a patch for that, should I send it to wine-devel-patches? wine-devel? winex-devel? Under what license would it fall? Or does that not matter? I have no idea what hidden snatches are in the transmeta licence, so I would like to use the LGPL. ;) Is there a problem with that for the transmeta guys or for you wine guys? Or would it fall automatically under the transmeta licence, since I am patching their source anyway? (You can tell I am confused ;) * Also, since I am a bit CVS challanged (newbie, I told you ;), is it okay to add my files directly in the CVS source tree with vi(m) and then send you a diff -u patch? Or do I need some CVS magic to do locally? Or just keep the file outside the CVS and then send a patch?
Thanx in advance,
Te"Wine, I am coooominng!"ls
- -- "Why do you go so slowly? Do you think this is some kind of game?" PGP key available on http://bloodgate.com/tels.asc or via email. perl -MDev::Bollocks -e'print Dev::Bollocks->rand(),"\n"' conveniently consolidate out-of-the-box ROI
On April 4, 2002 12:55 pm, Tels wrote:
wine-devel-patches? wine-devel? winex-devel? Under what license would it fall? Or does that not matter?
Patches for the public tree go to wine-patches and fall under LGPL unless you relicense them with another license. The transgaming tree is proprietary, and no code from it can go to the public tree unless transgaming donates it.
- Also, since I am a bit CVS challanged (newbie, I told you ;), is it okay to add my files directly in the CVS source tree with vi(m) and then send you a diff -u patch? Or do I need some CVS magic to do locally? Or just keep the file outside the CVS and then send a patch?
If you just modify some file, simply modify them in place, then do a cvs diff -u > mypatch.diff
If you also add some files, add them directly with vi, then do a
diff -uN path/to/your/new/file >> mypatch.diff
Then send mypatch.diff to wine-patches with an appropriate ChangeLog entry.
-----BEGIN PGP SIGNED MESSAGE-----
Moin,
On 04-Apr-02 Dimitrie O. Paun carved into stone:
On April 4, 2002 12:55 pm, Tels wrote:
wine-devel-patches? wine-devel? winex-devel? Under what license would it fall? Or does that not matter?
Patches for the public tree go to wine-patches and fall under LGPL unless you relicense them with another license.
Okay. LGPL for these parts then. Fine by me.
The transgaming tree is proprietary, and no code from it can go to the public tree unless transgaming donates it.
Okay. But that doesn't really answer my qustion, since it that case *I* am writing the code and not Transmeta (well, not sure if this matters ;).
Does my code fall automatically under the transgaming licence when I patch insise their CVS tree?
Can arrange that my code goes automatically public, or do I just have to hope that someday transmeta will release stuff (meaning that I work for free for transmeta, and they just hold on to my patches/work?)
Thanx in advance!
- Also, since I am a bit CVS challanged (newbie, I told you ;), is it
[snip]
If you just modify some file, simply modify them in place, then do a
Thank you for your explanations!
Cheers,
Tels
- -- "Why do you go so slowly? Do you think this is some kind of game?" PGP key available on http://bloodgate.com/tels.asc or via email. perl -MDev::Bollocks -e'print Dev::Bollocks->rand(),"\n"' vitalistically harness industry-wide e-business
On Thu, 4 Apr 2002, Tels wrote:
ddraw/user.c has comments like these:
/* GetDisplayMode: generic */ /* GetFourCCCodes: generic */ /* GetGDISurface: ??? */ /* GetMonitorFrequency: generic */ /* GetScanLine: generic */ /* GetSurfaceFromDC: generic */ /* GetVerticalBlankStatus: generic */ /* Initialize: generic */ /* RestoreAllSurfaces: generic */ /* RestoreDisplayMode: generic */ /* SetCooperativeLevel: ??? */
- What does the "generic" stand for? Return value? Function class?
Simply that the generic implementations in ddraw/main.c are used instead of reimplementing them in ddraw/user.c.
- It seems that SetCooperativeLevel associates a "value" (or more than one) with the givenwindow handle and TestCooperativeLevel let's you later check this status. Where would I store such a "global" value?
Somewhere in the IDirectDrawImpl structure. Most of this is already implemented in WineX, though. You can merge that code (but only the 2D parts) into main Wine if you want... I think I never got around to do it myself, we've worked in the next WineX release for far too long.
- If I understand it correctly, the directx stuff is done by transgaming. Their licence differs from the "normal" wine. (I am really unsure how all these things play together even after readin codeweavers.com, winehq.com and transgaming.com). So, if I send in a patch for that, should I send it to wine-devel-patches? wine-devel? winex-devel? Under what license would it fall? Or does that not matter?
Each list has a "default license", I suppose... the default license for both used to be the X11 license, until WineHQ changed licenses. Any code you want to see in WineX must be submitted under the X11 license. (Submitting only under the AFPL won't work since we want to release WineX under the X11 once we have enough subscribers.)
The X11 license is the license that allows sublicensing to any other license, including LGPL and AFPL, so both Wine and WineX can use it.
- Also, since I am a bit CVS challanged (newbie, I told you ;), is it okay to add my files directly in the CVS source tree with vi(m) and then send you a diff -u patch? Or do I need some CVS magic to do locally? Or just keep the file outside the CVS and then send a patch?
You can modify the source files and run "cvs diff -u" to diff against the repository itself, without keeping the original files around.
-
Dimitrie O. Paun -
Ove Kaaven -
Tels