Re: mapi32: Add DebugInfo to critical sections.

[Uwe Bonnes]

> > > > > "Jan" == Jan Zerebecki  writes:

Jan> --- If this patch is rejected from inclusion, please tell me why,
    Jan> as I would have to ask anyway.

Nice disclaimer ;-)

I wonder if it works?

mapi32: Add DebugInfo to critical sections.

[Jan Zerebecki]

On Sun, Mar 11, 2007 at 12:27:54PM +0100, Uwe Bonnes wrote:
> > > > > > "Jan" == Jan Zerebecki  writes:
> Jan> --- If this patch is rejected from inclusion, please tell me why,
> Jan> as I would have to ask anyway.
>
> Nice disclaimer ;-)
>
> I wonder if it works?

No, I guess usually doesn't. Except for the few rejections where
I get a direct reply from AJ, for all the rejections without a
reply from anyone (which I guess are most of the rejections) I
end up asking AJ on IRC. He then usually directly tells me why,
possibly followed by more Q&A if I don't fully get how he wants
something done or why that way.

This way of doing also tends to produce things similar to: me:
"Did you take a look at this patch yet?" AJ: "not yet" or "please
resend".

It also seems asking AJ every now and then about a patch, makes
him more likely to not miss that patch.

Some few changes also need much pestering of AJ, persistence and
a few tries each probably with contradicting and/or
miscommunicated requirements. But that usualy results in a better
solution.

That said, AJ does a realy good job in reviewing patches

Jan