Hi,
While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check?
Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=73967
Your paranoid android.
=== build (build log) ===
/home/winetest/tools/testbot/var/wine-exe32/dlls/user32/tests/../../../../wine/dlls/user32/tests/msg.c:18058: undefined reference to `test_ShowOwnedPopups' collect2: error: ld returned 1 exit status Makefile:1067: recipe for target 'user32_test.exe' failed Makefile:9573: recipe for target 'dlls/user32/tests' failed Task: The exe32 Wine build failed
=== debiant (build log) ===
/home/winetest/tools/testbot/var/wine-win32/dlls/user32/tests/../../../../wine/dlls/user32/tests/msg.c:18058: undefined reference to `test_ShowOwnedPopups' /home/winetest/tools/testbot/var/wine-win32/dlls/user32/tests/../../../../wine/dlls/user32/tests/msg.c:18058: undefined reference to `test_ShowOwnedPopups' collect2: error: ld returned 1 exit status collect2: error: ld returned 1 exit status Task: The win32 Wine build failed
=== debiant (build log) ===
/home/winetest/tools/testbot/var/wine-wow64/dlls/user32/tests/../../../../wine/dlls/user32/tests/msg.c:18058: undefined reference to `test_ShowOwnedPopups' /home/winetest/tools/testbot/var/wine-wow64/dlls/user32/tests/../../../../wine/dlls/user32/tests/msg.c:18058: undefined reference to `test_ShowOwnedPopups' collect2: error: ld returned 1 exit status collect2: error: ld returned 1 exit status Task: The wow64 Wine build failed
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512
Hi,
On 6/23/20 7:02 PM, Haidong Yu wrote:
+ popup = CreateWindowExA(WS_EX_LEFT | WS_EX_LTRREADING | WS_EX_RIGHTSCROLLBAR | WS_EX_TOOLWINDOW | WS_EX_LAYERED | WS_EX_NOACTIVATE, "TestWindowClass", "layeredWnd",
This line looks pretty too long for me, probably I need a bigger monitor. :)
+ WS_CLIPSIBLINGS | WS_CLIPCHILDREN | WS_VISIBLE | WS_POPUP, + 110, 110, 200, 200, hwnd, 0, 0, NULL);
+ SetLayeredWindowAttributes(popup, 0,150, LWA_ALPHA);
Is this really necessary for the test? And another nitpicking: please add a space after '0,'.
+ ShowWindow(hwnd, SW_SHOWNOACTIVATE); + flush_events(); + ok(GetWindowLongA(popup, GWL_STYLE)&WS_VISIBLE, "The window should be visible\n");
Nitpicking: please add spaces before and after '&'. And you might want to add a todo_wine to the test before you fix it.
@@ -17955,6 +17985,7 @@ START_TEST(msg) test_restore_messages(); test_invalid_window(); + test_ShowOwnedPopups();
Should be test_show_no_active() here instead? Also, is it possible to integrate the test into an existing function instead of creating a new one?
Thanks, Jactry
-
Haidong Yu -
Jactry Zeng -
Marvin