Re: Yet another round of redundand NULL checks before HeapFree (found by Smatch).

[Michael Stefaniuc]

Please disregard this patch as a false positive crept in.

Michael Stefaniuc wrote:
> hopefully this should be the last round of redundand NULL checks before
> HeapFree removals. I know, famous last words. But this time i have
> extended the redundant_null_check.pl Smatch script to find all non-null
> variables from arbitrary complex if-expressions and check that any of
> them dosn't get HeapFree'd on the truth path.
> diff --git a/dlls/msacm32/driver.c b/dlls/msacm32/driver.c
> index e537bc4..bec3526 100644
> --- a/dlls/msacm32/driver.c
> +++ b/dlls/msacm32/driver.c
> @@ -587,7 +587,7 @@ MMRESULT WINAPI acmDriverOpen(PHACMDRIVE
>      return MMSYSERR_NOERROR;
>   gotError:
>      WARN("failed: ret = %08x\n", ret);
> - if (pad && !pad->hDrvr)
> - if (!pad->hDrvr)

nice NULL pointer dereference.
> HeapFree(MSACM_hHeap, 0, pad);
>      return ret;
>  }

bye
    michael

gcc V4 problem ?

[Nick Law]

Hi Guys,

Hopefully somebody can give me some pointers on this. One of our Wow 
gamers  is  trying to install  wine  on his system and ./configure exits 
with a problem about not being able to compile. It looks like a problem 
with gcc but I can't really see what's causing it other than the 
-Voption. Are there any known issues or extra flags when running wines 
configure on a system with gcc version 4 ?

Here's the bit of the config.log the shows the problem

$ ./configure

## --------- ##
## Platform. ##
## --------- ##

hostname = sheky
uname -m = i686
uname -r = 2.6.12-10-386
uname -s = Linux
uname -v = #1 Fri Apr 28 13:13:44 UTC 2006

/usr/bin/uname -p = unknown
/bin/uname -X     = unknown

/bin/arch              = i686
/usr/bin/arch -k       = unknown
/usr/convex/getsysinfo = unknown
/usr/bin/hostinfo      = unknown
/bin/machine           = unknown
/usr/bin/oslevel       = unknown
/bin/universe          = unknown

PATH: /usr/local/sbin
PATH: /usr/local/bin
PATH: /usr/sbin
PATH: /usr/bin
PATH: /sbin
PATH: /bin
PATH: /usr/X11R6/bin

## ----------- ##
## Core tests. ##
## ----------- ##

configure:1875: checking build system type
configure:1893: result: i686-pc-linux-gnulibc1
configure:1915: checking host system type
configure:1930: result: i686-pc-linux-gnulibc1
configure:1984: checking whether make sets $(MAKE)
configure:2005: result: yes
configure:2062: checking for gcc
configure:2089: result: gcc
configure:2327: checking for C compiler version
configure:2329: gcc --version >&5
gcc (GCC) 4.0.2 20050808 (prerelease) (Ubuntu 4.0.1-4ubuntu9)
Copyright (C) 2005 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

configure:2332: $? = 0
configure:2334: gcc -v >&5
Using built-in specs.
Target: i486-linux-gnu
Configured with: ../src/configure -v
--enable-languages=c,c++,java,f95,objc,ada,treelang --prefix=/usr
--with-gxx-include-dir=/usr/include/c++/4.0.2 --enable-shared
--with-system-zlib --libexecdir=/usr/lib --enable-nls
--without-included-gettext --enable-threads=posix
--program-suffix=-4.0 --enable-__cxa_atexit
--enable-libstdcxx-allocator=mt --enable-clocale=gnu
--enable-libstdcxx-debug --enable-java-gc=boehm --enable-java-awt=gtk
--enable-gtk-cairo
--with-java-home=/usr/lib/jvm/java-1.4.2-gcj-4.0-1.4.2.0/jre
--enable-mpfr --disable-werror --enable-checking=release
i486-linux-gnu
Thread model: posix
gcc version 4.0.2 20050808 (prerelease) (Ubuntu 4.0.1-4ubuntu9)
configure:2337: $? = 0
configure:2339: gcc -V >&5
gcc: '-V' option must have argument
configure:2342: $? = 1
configure:2382: checking for C compiler default output file name
configure:2386: gcc    conftest.c  >&5
/usr/bin/ld: crt1.o: No such file: No such file or directory
collect2: ld returned 1 exit status
configure:2389: $? = 1
configure: failed program was:
| /* confdefs.h.  */
| #define PACKAGE_NAME "Wine"
| #define PACKAGE_TARNAME "wine"
| #define PACKAGE_VERSION "0.9.15"
| #define PACKAGE_STRING "Wine 0.9.15"

Regards
Nick Law

gcc V4 problem ?

[Marcus Meissner]

On Fri, Jun 09, 2006 at 08:35:14AM +0100, Nick Law wrote:
> Hi Guys,
>
> Hopefully somebody can give me some pointers on this. One of our Wow 
> gamers  is  trying to install  wine  on his system and ./configure exits 
> with a problem about not being able to compile. It looks like a problem 
> with gcc but I can't really see what's causing it other than the 
> -Voption. Are there any known issues or extra flags when running wines 
> configure on a system with gcc version 4 ?
> /usr/bin/ld: crt1.o: No such file: No such file or directory
> collect2: ld returned 1 exit status

He needs the glibc development package (glibc-devel called on some RPM systems).

Ciao, Marcus