On 8/6/08, Martin Profittlich martin.profittlich@gmx.de wrote:
Hello!
This patch fixes bug 14781 (http://bugs.winehq.org/show_bug.cgi?id=14781).
Some Native Instruments apps like Kontakt 3 and Kore Player crash on startup, shortly after calling RegisterDeviceNotificationW(). This stub currently returns a 0 for failure. RegisterDeviceNotificationA() otoh returns a fake handle. This patch makes RegisterDeviceNotificationW() do this also. This makes both apps work.
This is my first submission. Please let me know if the format is wrong or some important information is missing.
Martin
Ist Ihr Browser Vista-kompatibel? Jetzt die neuesten Browser-Versionen downloaden: http://www.gmx.net/de/go/browser
Martin,
Your patch is more likely to be accepted if it comes with a test which works on windows, didnt pass in wine before but passes now and demonstrates why the new behavior is correct.
--Zach
"Zachary Goldberg" zgold550@gmail.com wrote:
Your patch is more likely to be accepted if it comes with a test which works on windows, didnt pass in wine before but passes now and demonstrates why the new behavior is correct.
There is no need for a test since that's not really an implementation but just a better stub which follows existing code.