[PATCH 6/6] xactengine3_7: Implement IXACT3Engine::RegisterNotification and IXACT3Engine::UnRegisterNotification functions.
Based on patch from Ethan Lee.
Signed-off-by: Vijay Kiran Kamuju infyquest@gmail.com
Hi,
While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check?
Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=76547
Your paranoid android.
=== debiant (build log) ===
error: patch failed: dlls/xactengine3_7/xact_dll.c:318 error: patch failed: dlls/xactengine3_7/xact_dll.c:318 error: patch failed: dlls/xactengine3_7/xact_dll.c:269 error: patch failed: dlls/xactengine3_7/xact_dll.c:561 Task: Patch failed to apply
=== debiant (build log) ===
error: patch failed: dlls/xactengine3_7/xact_dll.c:318 error: patch failed: dlls/xactengine3_7/xact_dll.c:318 error: patch failed: dlls/xactengine3_7/xact_dll.c:269 error: patch failed: dlls/xactengine3_7/xact_dll.c:561 Task: Patch failed to apply
Hi Vijay,
On 6/8/20 7:48 am, Vijay Kiran Kamuju wrote:
Based on patch from Ethan Lee.
Signed-off-by: Vijay Kiran Kamuju infyquest@gmail.com
unwrap of this structure can cause random crashes as application don't zero the structure passed in. Please look at patch xactengine 0009 in staging and use flags to copy only the bits it needs.
Regards Alistair
On Thu, Aug 6, 2020 at 12:33 AM Alistair Leslie-Hughes leslie_alistair@hotmail.com wrote:
Hi Vijay,
On 6/8/20 7:48 am, Vijay Kiran Kamuju wrote:
Based on patch from Ethan Lee.
Signed-off-by: Vijay Kiran Kamuju infyquest@gmail.com
unwrap of this structure can cause random crashes as application don't zero the structure passed in. Please look at patch xactengine 0009 in staging and use flags to copy only the bits it needs.
I will incorporate the necessary bits and send a new version in a few minutes.
Regards Alistair
Regards, Vijay
-
Alistair Leslie-Hughes -
Marvin -
Vijay Kiran Kamuju