[PATCH] schannel/tests: Relax GetInfo return value test

[Alex Henrie]

Signed-off-by: Alex Henrie 
---
This test has failed on the Windows 8 and Windows 10 testbot VMs since
January 19, most likely because of some Windows update. I wasn't able to
figure out what the seemingly random return codes mean, but they're not
errors.

dlls/schannel/tests/main.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/dlls/schannel/tests/main.c b/dlls/schannel/tests/main.c
index fb350d5e62..fc913c14a9 100644
--- a/dlls/schannel/tests/main.c
+++ b/dlls/schannel/tests/main.c
@@ -219,11 +219,11 @@ static void testGetInfo(void)
         return;
     }
     status = pTables->GetInfo(&PackageInfo);
-    ok(status == STATUS_SUCCESS ||
+    ok(SUCCEEDED(status) ||
        status == SEC_E_UNSUPPORTED_FUNCTION, /* win2k3 */
        "status: 0x%x\n", status);

-    if (status == STATUS_SUCCESS)
+    if (SUCCEEDED(status))
     {
         ok(PackageInfo.fCapabilities == LSA_BASE_CAPS ||
            PackageInfo.fCapabilities == (LSA_BASE_CAPS|SECPKG_FLAG_APPCONTAINER_PASSTHROUGH),

[Dmitry Timoshkov]

Alex Henrie  wrote:
>  status = pTables->GetInfo(&PackageInfo);
> - ok(status == STATUS_SUCCESS ||
> - ok(SUCCEEDED(status) ||
>    status == SEC_E_UNSUPPORTED_FUNCTION, /* win2k3 */
>    "status: 0x%x\n", status);
> - if (status == STATUS_SUCCESS)
> - if (SUCCEEDED(status))
> {
>     ok(PackageInfo.fCapabilities == LSA_BASE_CAPS ||
>        PackageInfo.fCapabilities == (LSA_BASE_CAPS|SECPKG_FLAG_APPCONTAINER_PASSTHROUGH),

SUCCEEDED() is supposed to be used for HRESULT codes not for NTSTATUS ones.
But in this particular case this mess could be attributed directly to MS,
as SSP/AP interfaces are declared to return NTSTATUS, but in reality they
do return HRESULT (or rather SECURITY_STATUS) values.