Re: wininet: parse cookie information from cookie value

[Rob Shearman]

2009/2/13 Aric Stewart :
> -
>    if (CompareStringW(GetThreadLocale(), NORM_IGNORECASE, ptr, 6,
> -
>                       szDomain, 6) == 2)

LOCALE_INVARIANT should be used when comparing with a constant string.
See here for the reasons why:
http://blogs.msdn.com/michkap/archive/2004/12/29/344136.aspx
http://blogs.msdn.com/larryosterman/archive/2004/07/01/171078.aspx
http://msdn.microsoft.com/en-us/library/dd373795(VS.85).aspx

It doesn't look like it's implemented in Wine, so I guess you should
just use MAKELCID(LANG_ENGLISH, SUBLANG_DEFAULT) with a FIXME to use
LOCALE_INVARIANT when it's implemented.

And, yes, there's probably lots of other places where we do case
insensitive comparisons incorrectly like this, but we should stop
introducing new ones.

wininet: parse cookie information from cookie value

[Aric Stewart]

Thanks for the tip.

Resent.
-aric

Rob Shearman wrote:
> 2009/2/13 Aric Stewart :
> > -
> >    if (CompareStringW(GetThreadLocale(), NORM_IGNORECASE, ptr, 6,
> > -
> >                       szDomain, 6) == 2)
>
> LOCALE_INVARIANT should be used when comparing with a constant string.
> See here for the reasons why:
> http://blogs.msdn.com/michkap/archive/2004/12/29/344136.aspx
> http://blogs.msdn.com/larryosterman/archive/2004/07/01/171078.aspx
> http://msdn.microsoft.com/en-us/library/dd373795(VS.85).aspx
>
> It doesn't look like it's implemented in Wine, so I guess you should
> just use MAKELCID(LANG_ENGLISH, SUBLANG_DEFAULT) with a FIXME to use
> LOCALE_INVARIANT when it's implemented.
>
> And, yes, there's probably lots of other places where we do case
> insensitive comparisons incorrectly like this, but we should stop
> introducing new ones.