Re: [PATCH] winemac.drv: Advertise some legacy WGL extensions in the GL_EXTENSIONS string. (try 2)

[Ken Thomases]

On Jul 24, 2013, at 9:34 PM, Charles Davis wrote:
> Try 2: Don't duplicate a constant string; we might need to add more legacy
>       extensions. (Hopefully not. ;)

Thanks for making that change.  Looks good to me.

Cheers,
Ken

[PATCH] winemac.drv: Advertise some legacy WGL extensions in the GL_EXTENSIONS string. (try 2)

[Ken Thomases]

On Jul 24, 2013, at 9:41 PM, Ken Thomases wrote:
> On Jul 24, 2013, at 9:34 PM, Charles Davis wrote:
> > Try 2: Don't duplicate a constant string; we might need to add more legacy
> >      extensions. (Hopefully not. ;)
>
> Thanks for making that change.  Looks good to me.

Actually, on further thought I realize that we shouldn't be advertising WGL_EXT_swap_control unconditionally.  It should be controlled by the AllowVerticalSync registry setting / allow_vsync variable.  See load_extensions().  If vsync is disallowed, the corresponding functions are left as NULL in the OpenGL function table, so clients may crash if WGL_EXT_swap_control is advertised.

Regards,
Ken

[PATCH] winemac.drv: Advertise some legacy WGL extensions in the GL_EXTENSIONS string. (try 2)

[Ken Thomases]

On Jul 25, 2013, at 9:57 AM, Ken Thomases wrote:
> If vsync is disallowed, the corresponding functions are left as NULL in the OpenGL function table, so clients may crash if WGL_EXT_swap_control is advertised.

Well, this part is wrong.  They won't crash because opengl32 protects against that, but still we shouldn't advertise it if support for it is disabled.

-Ken