Re: [PATCH 6/7] ws2_32: implement AcceptEx

[Juan Lang]

Hi Mike, I have one minor nit on this patch:

+    if (wsa->read) HeapFree( GetProcessHeap(), 0, wsa->read );
Please don't check if (wsa->read) is NULL before calling HeapFree.
HeapFree already does the correct thing given NULL, and we had a bunch
of patches to remove checks like this.
--Juan

[PATCH 6/7] ws2_32: implement AcceptEx

[Mike Kaplinskiy]

On Fri, Aug 28, 2009 at 2:01 PM, Juan Lang wrote:
> Hi Mike, I have one minor nit on this patch:
> - if (wsa->read) HeapFree( GetProcessHeap(), 0, wsa->read );
>
> Please don't check if (wsa->read) is NULL before calling HeapFree.
> HeapFree already does the correct thing given NULL, and we had a bunch
> of patches to remove checks like this.
> --Juan

I did not know that, thanks Juan. I'll resend the batch.

Mike.