RtlUpperChar (was: some ntdll functions) [Virus checked]

"Dmitry Timoshkov"  wrote:
> > IMHO RtlUpperChar has nothing to do for unicode chars.
> > Is there a way to use Wine internal code page to do the conversion

without
> > converting to unicode and back?
>
> Wine has only unicode case conversion tables and currently there is no

way
> to avoid forth and back conversions.

My solution for this is:

/**************************************************************************
 *   RtlUpperChar   (NTDLL.@)
 */
CHAR WINAPI RtlUpperChar( CHAR ch )
{
    WCHAR wch;

wch = toupperW(((WCHAR) ch) & 0xff);
    if (wch >> 8) {
        return ch;
    } else {
        return (CHAR) wch;
    }
}

This would mean: Some ISO Latin 1 characters would be converted
additionally
to 'a' .. 'z'.

I did a test on w2k trying to convert all chars between 0 and 255.
The result was:

Just 'a' .. 'z' are converted to 'A' .. 'Z', all other characters remain
unchanged.

I switched the machine between 'EN' (English) and 'DE' (German) and no
difference.
May be this was the wrong place to switch the locale / code pages ...
My guess is:

RtlUpperChar does not take the locale into account. It always convertes
just
'a' .. 'z' and nothing else.

Is this the right direction or did I miss something?

Greetings
Thomas

[Dan Kegel]

[e-mail] wrote:
> My solution for this is:
> ...
> CHAR WINAPI RtlUpperChar( CHAR ch )
> {
>     WCHAR wch;
> wch = toupperW(((WCHAR) ch) & 0xff);
> if (wch >> 8) {
>     return ch;
> } else {
>     return (CHAR) wch;
> }
>
> }

That looks like a horrible kludge.  Before we settle on
something like this, we should probably consult the
people on the unicode mailing list to see what they
suggest.
- Dan

[Dmitry Timoshkov]

 wrote:
> RtlUpperChar does not take the locale into account. It always convertes
> just
> 'a' .. 'z' and nothing else.
>
> Is this the right direction or did I miss something?

No, that's not right. We really need to convert to unicode first, then
upper case unicode character and convert the result back to ansi. See
the ReactOS source for reference (at the first glance it closely enough
matches NTDLL asm code).