Signed-off-by: Alex Henrie alexhenrie24@gmail.com --- I think this will help prevent the testbot from crashing intermittently in check_release(sprite, 0). --- dlls/d3dx9_36/tests/core.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/dlls/d3dx9_36/tests/core.c b/dlls/d3dx9_36/tests/core.c index a8477591e87..ea2d1e4465b 100644 --- a/dlls/d3dx9_36/tests/core.c +++ b/dlls/d3dx9_36/tests/core.c @@ -319,6 +319,8 @@ static void test_ID3DXSprite(IDirect3DDevice9 *device) ok (hr == D3D_OK, "Begin returned %#x, expected %#x\n", hr, D3D_OK); hr = ID3DXSprite_Draw(sprite, tex2, &rect, ¢er, &pos, D3DCOLOR_XRGB(255, 255, 255)); ok (hr == D3D_OK, "Draw returned %#x, expected %#x\n", hr, D3D_OK); + hr = ID3DXSprite_End(sprite); + ok (hr == D3D_OK, "End returned %#x, expected %#x\n", hr, D3D_OK);
IDirect3DDevice9_EndScene(device); check_release((IUnknown*)sprite, 0);
Signed-off-by: Matteo Bruni mbruni@codeweavers.com --- Actually the test seems to crash most of the times while releasing tex2 (e.g. http://test.winehq.org/data/529e4154a34a5a774fe7036552ffbb060740da90/ win81_newtb-w864-64/d3dx9_36:core.html), sometimes while releasing tex1 (http://test.winehq.org/data/9ef5c9c0090f17df5bfd794485019fb8bf9a7e25/ win21H1_newtb-w10pro64-zh-CN-64/d3dx9_36:core.html). At any rate, there is probably some weird bug in native but we don't care much about its details and I don't see any reason not to introduce the missing End().