[PATCH v2 1/4] winmm/tests: Expect TIME_BYTES format for requesting TIME_MS.

[Akihiro Sagawa]

In v2,
   Update conformance tests to avoid redundant position tests which
occasionally fail on some VMs.

Signed-off-by: Akihiro Sagawa 
---
 dlls/winmm/tests/wave.c | 32 ++++++++++++++++----------------
 1 file changed, 16 insertions(+), 16 deletions(-)

[Marvin]

Hi,

While running your changed tests, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?

Full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=84198

Your paranoid android.

=== w1064 (64 bit report) ===

winmm:
wave.c:803: Test failed: missing WOM_DONE notification
wave.c:808: Test failed: (05) WHDR_DONE WHDR_PREPARED expected, got WHDR_INQUEUE WHDR_PREPARED
wave.c:808: Test failed: (06) WHDR_DONE WHDR_PREPARED expected, got WHDR_INQUEUE WHDR_PREPARED
wave.c:808: Test failed: (07) WHDR_DONE WHDR_PREPARED expected, got WHDR_INQUEUE WHDR_PREPARED
wave.c:808: Test failed: (08) WHDR_DONE WHDR_PREPARED expected, got WHDR_INQUEUE WHDR_PREPARED
wave.c:808: Test failed: (09) WHDR_DONE WHDR_PREPARED expected, got WHDR_INQUEUE WHDR_PREPARED
wave.c:501: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 1356 bytes, should be 17640
wave.c:512: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 1356 samples (1356 bytes), should be 17640 (17640 bytes)
wave.c:819: Test failed: waveOutUnprepareHeader(WAVE_MAPPER): rc=WAVERR_STILLPLAYING(Cannot perform this operation while media data is still playing.  Reset the device, or wait until the data is finished playing.)
wave.c:819: Test failed: waveOutUnprepareHeader(WAVE_MAPPER): rc=WAVERR_STILLPLAYING(Cannot perform this operation while media data is still playing.  Reset the device, or wait until the data is finished playing.)
wave.c:819: Test failed: waveOutUnprepareHeader(WAVE_MAPPER): rc=WAVERR_STILLPLAYING(Cannot perform this operation while media data is still playing.  Reset the device, or wait until the data is finished playing.)
wave.c:819: Test failed: waveOutUnprepareHeader(WAVE_MAPPER): rc=WAVERR_STILLPLAYING(Cannot perform this operation while media data is still playing.  Reset the device, or wait until the data is finished playing.)
wave.c:819: Test failed: waveOutUnprepareHeader(WAVE_MAPPER): rc=WAVERR_STILLPLAYING(Cannot perform this operation while media data is still playing.  Reset the device, or wait until the data is finished playing.)
wave.c:803: Test failed: missing WOM_DONE notification
wave.c:803: Test failed: missing WOM_DONE notification

=== w1064_2qxl (64 bit report) ===

winmm:
wave.c:501: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 1356 bytes, should be 13230
wave.c:512: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 1356 samples (1356 bytes), should be 13230 (13230 bytes)

[Andrew Eikum]

On Tue, Jan 19, 2021 at 09:55:23PM +0900, Akihiro Sagawa wrote:
> In v2,
>    Update conformance tests to avoid redundant position tests which
> occasionally fail on some VMs.

I don't know if removing the test is the right thing to do. You could
look into why they are failing, or just make the changes as if it
passed, and I can ignore the existing test failures.

Andrew

[Akihiro Sagawa]

On Tue, 19 Jan 2021 11:59:15 -0600, Andrew Eikum wrote:
> On Tue, Jan 19, 2021 at 09:55:23PM +0900, Akihiro Sagawa wrote:
> > In v2,
> >    Update conformance tests to avoid redundant position tests which
> > occasionally fail on some VMs.
>
> I don't know if removing the test is the right thing to do. You could
> look into why they are failing, or just make the changes as if it
> passed, and I can ignore the existing test failures.

Got it. I'll follow the latter way and send updated patch derived from
v1 (not v2).

Akihiro Sagawa