Hi Bernhard, Build fails here:
loader.c: In function ‘test_section_mapping’: loader.c:706:9: error: unused variable ‘i’ [-Werror=unused-variable] cc1: all warnings being treated as errors make[1]: *** [loader.o] Error 1 make[1]: Leaving directory `/home/bob/wineslave.dir/sandbox/slave/runtests-default/build/dlls/kernel32/tests' make: *** [dlls/kernel32/tests] Error 2
http://buildbot.kegel.com:8010/builders/runtests-default/builds/159
Can you fix and resubmit the series?
On Tue, Oct 11, 2011 at 6:06 PM, Dan Kegel dank@kegel.com wrote:
Hi Bernhard, Build fails here:
loader.c: In function ‘test_section_mapping’: loader.c:706:9: error: unused variable ‘i’ [-Werror=unused-variable] cc1: all warnings being treated as errors make[1]: *** [loader.o] Error 1 make[1]: Leaving directory `/home/bob/wineslave.dir/sandbox/slave/runtests-default/build/dlls/kernel32/tests' make: *** [dlls/kernel32/tests] Error 2
http://buildbot.kegel.com:8010/builders/runtests-default/builds/159
Can you fix and resubmit the series?
It gets used in patch 2/2, that's why I overlooked it. Should I still resubmit it, as it would be only broken for a single revision?
On Tue, Oct 11, 2011 at 9:10 AM, Bernhard Loos bernhardloos@googlemail.com wrote:
It gets used in patch 2/2, that's why I overlooked it. Should I still resubmit it, as it would be only broken for a single revision?
It would be nice; that way the tree is a bit easier to bisect, etc, but mostly that way your patch series will actually be tested by the buildbot.
On Tuesday 11 October 2011 18:15:29 Dan Kegel wrote:
On Tue, Oct 11, 2011 at 9:10 AM, Bernhard Loos
bernhardloos@googlemail.com wrote:
It gets used in patch 2/2, that's why I overlooked it. Should I still resubmit it, as it would be only broken for a single revision?
It would be nice; that way the tree is a bit easier to bisect, etc, but mostly that way your patch series will actually be tested by the buildbot.
I think Alexandre builds with -Werror, so he wouldn't apply your patches anyway.
Incidentally, the reason no automatic email was sent was that gcc still has those nonascii characters in its output, even though I set LANG=C. I'm now adding more logging to see what's up.
On Tue, Oct 11, 2011 at 9:06 AM, Dan Kegel dank@kegel.com wrote:
Hi Bernhard, Build fails here:
loader.c: In function ‘test_section_mapping’: loader.c:706:9: error: unused variable ‘i’ [-Werror=unused-variable] cc1: all warnings being treated as errors make[1]: *** [loader.o] Error 1 make[1]: Leaving directory `/home/bob/wineslave.dir/sandbox/slave/runtests-default/build/dlls/kernel32/tests' make: *** [dlls/kernel32/tests] Error 2
http://buildbot.kegel.com:8010/builders/runtests-default/builds/159
Can you fix and resubmit the series?