Re: [PATCH] wine.inf: Add some knownfolders to the registry

[Alexandre Julliard]

Andrew Eikum  writes:
> This time with a cleaned up win8 testbot.
>
> dlls/shell32/tests/shellpath.c | 212 ++++++++++++++++++++---------------------
>  loader/wine.inf.in             |  24 +++++
>  2 files changed, 129 insertions(+), 107 deletions(-)

Shouldn't this be generated from the data we already have in shell32?

[PATCH] wine.inf: Add some knownfolders to the registry

[Andrew Eikum]

On Fri, Mar 13, 2015 at 09:07:06PM +0900, Alexandre Julliard wrote:
> Andrew Eikum  writes:
> > This time with a cleaned up win8 testbot.
> >
> > dlls/shell32/tests/shellpath.c | 212 ++++++++++++++++++++---------------------
> >  loader/wine.inf.in             |  24 +++++
> >  2 files changed, 129 insertions(+), 107 deletions(-)
>
> Shouldn't this be generated from the data we already have in shell32?

Sure. Is shell32.DllInstall the appropriate place to register these
folders in the registry, or did you have something else in mind?

Andrew

[PATCH] wine.inf: Add some knownfolders to the registry

[Alexandre Julliard]

Andrew Eikum  writes:
> On Fri, Mar 13, 2015 at 09:07:06PM +0900, Alexandre Julliard wrote:
> > Shouldn't this be generated from the data we already have in shell32?
>
> Sure. Is shell32.DllInstall the appropriate place to register these
> folders in the registry, or did you have something else in mind?

It should be done during dll registration, so not in DllInstall but more
likely somewhere in SHELL_RegisterShellFolders or one of its
subfunctions.