Re: [PATCH] ddraw/tests: Avoid dereferencing a null pointer in case of failure.

[Henri Verbeet]

On 22 October 2017 at 00:32, Zebediah Figura  wrote:
> This should fix a persistent crash on one of the XP test machines.
> Signed-off-by: Zebediah Figura

Why does it fail? It shouldn't. Does this run against Microsoft's
ddraw, or against some VM replacement?

[PATCH] ddraw/tests: Avoid dereferencing a null pointer in case of failure.

[Zebediah Figura]

On 10/23/2017 02:29 AM, Henri Verbeet wrote:
> On 22 October 2017 at 00:32, Zebediah Figura  wrote:
> > This should fix a persistent crash on one of the XP test machines.
> > Signed-off-by: Zebediah Figura
>
> Why does it fail? It shouldn't. Does this run against Microsoft's
> ddraw, or against some VM replacement?

Hmm, I don't know; I just assumed it would be good to fix. It's this one:

http://test.winehq.org/data/aef2f0799f09595f3458d3495e85bba0c9059865/xp_xpsp...

[PATCH] ddraw/tests: Avoid dereferencing a null pointer in case of failure.

[Henri Verbeet]

On 23 October 2017 at 16:20, Zebediah Figura  wrote:
> On 10/23/2017 02:29 AM, Henri Verbeet wrote:
> > On 22 October 2017 at 00:32, Zebediah Figura  wrote:
> > > This should fix a persistent crash on one of the XP test machines.
> > > Signed-off-by: Zebediah Figura
> >
> > Why does it fail? It shouldn't. Does this run against Microsoft's
> > ddraw, or against some VM replacement?
>
> Hmm, I don't know; I just assumed it would be good to fix. It's this one:
>
> http://test.winehq.org/data/aef2f0799f09595f3458d3495e85bba0c9059865/xp_xpsp...

"VirtualBox Graphics Adapter"

If we care to avoid the crash, it would perhaps be best to just skip
(using something along the lines of is_warp()) all the tests at the
start. VirtualBox results aren't going to be meaningful.