Re: [PATCH 1/5] d3dx9_36: Implement D3DXHANDLE more robustly

[Henri Verbeet]

On 5 July 2011 23:45, Travis Athougies  wrote:
> Fixes bug 26583.
>
> Allows deadspace 2 to run without native dlls.

This contains no useful information about what issue this is supposed
to fix, unless you expect people to actually debug it themselves
first. And I even went through the trouble to lookup the bug.
> +static WORD new_handle_with_desc_and_name(ID3DXConstantTableImpl* This, D3DXCONSTANT_DESC* desc, LPCSTR name, LPCSTR full_name)
> +{
> - ++This->handle_count;
> - if (This->handles)
> - This->handles = HeapReAlloc(GetProcessHeap(), 0, This->handles, sizeof(ctab_handle) * This->handle_count);
> - else
> - This->handles = HeapAlloc(GetProcessHeap(), 0, sizeof(ctab_handle) * This->handle_count);
> -
> - This->handles[This->handle_count - 1].desc = *desc;
> - This->handles[This->handle_count - 1].desc.Name = strdup(name);
> - This->handles[This->handle_count - 1].full_name = strdup(full_name);
> -
> - return This->handle_count;
>
> +}

That's just terrible.