Re: [dx8-5] Windows never reports 24 bit screen depths

[Ann and Jason Edmeades]

(Apologies for the duplicate sent - Didnt put a subject on first time)
> > Windows never reports 24 bit colours, and some games fail to work unless

in
> > specific modes. Report 16bit colour for 24bit modes
> Out of curiosity, in that case, why report 24 bits at all ? Why not just
> report 8, 16 and 32 ?

I dont - I query it with GetDeviceCaps and this is what gets returned.
        hdc = CreateDCA("DISPLAY", NULL, NULL, NULL);
        bpp = GetDeviceCaps(hdc, BITSPIXEL);
        DeleteDC(hdc);

Actually, all the screen handling in the dx8 code is awful (I can say that
as I put it there...).

I am hoping that if the recent changes to the window modes is implemented, I
can use that code to query what modes this device supports, and to change
the mode/resolution appropriately. The code that we have is a semi working
stopgap really.

Jason

[dx8-5] Windows never reports 24 bit screen depths

[Lionel Ulmer]

> I dont - I query it with GetDeviceCaps and this is what gets returned.
>         hdc = CreateDCA("DISPLAY", NULL, NULL, NULL);
>         bpp = GetDeviceCaps(hdc, BITSPIXEL);
>         DeleteDC(hdc);
>
> Actually, all the screen handling in the dx8 code is awful (I can say that
> as I put it there...).

Well, this is related to the other thread about the resolution change
patch... Wine should NOT return '24' here but '32'.

In Windows, '24' here means really 24/24 mode (which is not 3D accelerated
on any hardware I know).

So a better 'hack' would be to have 24 equivalent to 32.

Lionel

[dx8-5] Windows never reports 24 bit screen depths

[Ann and Jason Edmeades]

> > I dont - I query it with GetDeviceCaps and this is what gets returned.
> >         hdc = CreateDCA("DISPLAY", NULL, NULL, NULL);
> >         bpp = GetDeviceCaps(hdc, BITSPIXEL);
> >         DeleteDC(hdc);
>
> Well, this is related to the other thread about the resolution change
> patch... Wine should NOT return '24' here but '32'.
> In Windows, '24' here means really 24/24 mode (which is not 3D accelerated
> on any hardware I know).
>
> So a better 'hack' would be to have 24 equivalent to 32.

Sure, I can do that - I originally did, in fact, but decided to go for 16
bit since it felt more 'right' following the logic that you could run 16bit
colour on a 24bit display, but not 32 bit colour on a 24 bit display.

If you feel strongly about it, I'll resubmit making it a 32 mode, otherwise
I hope to get the modes more 'properly' implemented later on if I can ever
work out how to get it right!

Jason

[dx8-5] Windows never reports 24 bit screen depths

[Lionel Ulmer]

> If you feel strongly about it, I'll resubmit making it a 32 mode, otherwise
> I hope to get the modes more 'properly' implemented later on if I can ever
> work out how to get it right!

Oh don't bother... Was just to point out yet another case of this
BITSPERPIXEL stuff playing dirty tricks on people :-)

Lionel