Any more infos about the build failure for my (small) patch

[Uwe Bonnes]

Hello,

on my Suse 11.3, /usr/include/ssl/ssl.h defines
const SSL_METHOD *method;
as does http://www.openssl.org/docs/ssl/ssl.html
and so in 
../dlls/winhttp/net.c and ../dlls/wininet/netconnection.c

static SSL_METHOD *method;
is flagges as an warning.

My patch exchanged
-static SSL_METHOD *method;
+static const SSL_METHOD *method;

but
http://source.winehq.org/patches/
flags
63746	Build failure	Uwe Bonnes 	Add-missing-const-qualifier.patc

Can anybody give more information?

[Paul Vriens]

On 07/23/2010 10:53 AM, Uwe Bonnes wrote:
> Hello,
>
> on my Suse 11.3, /usr/include/ssl/ssl.h defines
> const SSL_METHOD *method;
> as does http://www.openssl.org/docs/ssl/ssl.html
> and so in
> ../dlls/winhttp/net.c and ../dlls/wininet/netconnection.c
>
> static SSL_METHOD *method;
> is flagges as an warning.
>
> My patch exchanged
> -static SSL_METHOD *method;
> +static const SSL_METHOD *method;
>
> but
> http://source.winehq.org/patches/
> flags
> 63746	Build failure	Uwe Bonnes 	Add-missing-const-qualifier.patc
>
> Can anybody give more information?

Haven't checked the code, but these are the extra warnings I get for 
winhttp:

../../../wine-git/dlls/winhttp/net.c: In function ‘netconn_init’:
../../../wine-git/dlls/winhttp/net.c:479: warning: passing argument 1 of 
‘pSSL_CTX_new’ discards qualifiers from pointer target type
../../../wine-git/dlls/winhttp/net.c:479: note: expected ‘struct 
SSL_METHOD *’ but argument is of type ‘const struct SSL_METHOD *’

[Paul Vriens]

On 07/23/2010 11:18 AM, Paul Vriens wrote:
> On 07/23/2010 10:53 AM, Uwe Bonnes wrote:
> > Hello,
> >
> > on my Suse 11.3, /usr/include/ssl/ssl.h defines
> > const SSL_METHOD *method;
> > as does http://www.openssl.org/docs/ssl/ssl.html
> > and so in
> > ../dlls/winhttp/net.c and ../dlls/wininet/netconnection.c
> >
> > static SSL_METHOD *method;
> > is flagges as an warning.
> >
> > My patch exchanged
> > -static SSL_METHOD *method;
> > +static const SSL_METHOD *method;
> >
> > but
> > http://source.winehq.org/patches/
> > flags
> > 63746 Build failure Uwe Bonnes Add-missing-const-qualifier.patc
> >
> > Can anybody give more information?
>
> Haven't checked the code, but these are the extra warnings I get for
> winhttp:
>
> ../../../wine-git/dlls/winhttp/net.c: In function ‘netconn_init’:
> ../../../wine-git/dlls/winhttp/net.c:479: warning: passing argument 1 of
> ‘pSSL_CTX_new’ discards qualifiers from pointer target type
> ../../../wine-git/dlls/winhttp/net.c:479: note: expected ‘struct
> SSL_METHOD *’ but argument is of type ‘const struct SSL_METHOD *’

And this is what my include file shows:

SSL_CTX *SSL_CTX_new(SSL_METHOD *meth);
  61557   88 -rw-r--r--   1 root     root        87238 Jun  2 11:11 
./usr/include/openssl/ssl.h

On Fedora 11:

openssl-0.9.8n-2.fc11.x86_64
openssl-0.9.8n-2.fc11.i686

[Uwe Bonnes]

> > > > > "Paul" == Paul Vriens  writes:

>>

Paul> And this is what my include file shows:

Paul> SSL_CTX *SSL_CTX_new(SSL_METHOD *meth); 61557 88 -rw-r--r-- 1 root
    Paul> root 87238 Jun 2 11:11 ./usr/include/openssl/ssl.h

Ah, Readhat defining in it's own way.
What about debian?

Isn't the OpenSSL documentation way th way it should be?

[Octavian Voicu]

On Fri, Jul 23, 2010 at 12:32 PM, Uwe Bonnes
 wrote:
> Paul> SSL_CTX *SSL_CTX_new(SSL_METHOD *meth); 61557 88 -rw-r--r-- 1 root
>    Paul> root 87238 Jun 2 11:11 ./usr/include/openssl/ssl.h
>
> Ah, Readhat defining in it's own way.
> What about debian?
>
> Isn't the OpenSSL documentation way th way it should be?

Ubuntu also has /usr/include/openssl/ssl.h.
Linux manpages show the same thing: http://linux.die.net/man/3/ssl_ctx_new

Maybe this should go in autoconf?

Octavian