This is enabled as an error by default starting with XCode 12. Will prevent breaking the Staging CI.
Signed-off-by: Gijs Vermeulen gijsvrm@gmail.com --- configure.ac | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/configure.ac b/configure.ac index 5c364bef0d9..101eafb478d 100644 --- a/configure.ac +++ b/configure.ac @@ -1044,6 +1044,7 @@ then WINE_TRY_CROSSCFLAGS([-Wdeclaration-after-statement]) WINE_TRY_CROSSCFLAGS([-Wempty-body]) WINE_TRY_CROSSCFLAGS([-Wignored-qualifiers]) + WINE_TRY_CROSSCFLAGS([-Wimplicit-function-declaration]) WINE_TRY_CROSSCFLAGS([-Winit-self]) WINE_TRY_CROSSCFLAGS([-Wpacked-not-aligned],[EXTRACROSSCFLAGS="$EXTRACROSSCFLAGS -Wno-packed-not-aligned"]) WINE_TRY_CROSSCFLAGS([-Wpragma-pack],[EXTRACROSSCFLAGS="$EXTRACROSSCFLAGS -Wno-pragma-pack"]) @@ -2016,6 +2017,7 @@ then WINE_TRY_CFLAGS([-Wdeclaration-after-statement]) WINE_TRY_CFLAGS([-Wempty-body]) WINE_TRY_CFLAGS([-Wignored-qualifiers]) + WINE_TRY_CFLAGS([-Wimplicit-function-declaration]) WINE_TRY_CFLAGS([-Winit-self]) WINE_TRY_CFLAGS([-Wpacked-not-aligned],[EXTRACFLAGS="$EXTRACFLAGS -Wno-packed-not-aligned"]) WINE_TRY_CFLAGS([-Wpragma-pack],[EXTRACFLAGS="$EXTRACFLAGS -Wno-pragma-pack"])
Signed-off-by: Dean M Greer gcenx83@gmail.com --- Here’s the information on this change if needed, some of the recent patches from Zebediah and Alistair have been to resolve issues related to this.
Wine-Staging now builds wine-devel and wine-staging on each rebase for macOS using GitHub actions.
# Xcode12 by default enables '-Werror,-Wimplicit-function-declaration' (49917738) # https://developer.apple.com/documentation/xcode-release-notes/xcode-12-relea...
On 4/9/21 10:42 AM, Gijs Vermeulen wrote:
This is enabled as an error by default starting with XCode 12. Will prevent breaking the Staging CI.
Signed-off-by: Gijs Vermeulen gijsvrm@gmail.com
configure.ac | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/configure.ac b/configure.ac index 5c364bef0d9..101eafb478d 100644 --- a/configure.ac +++ b/configure.ac @@ -1044,6 +1044,7 @@ then WINE_TRY_CROSSCFLAGS([-Wdeclaration-after-statement]) WINE_TRY_CROSSCFLAGS([-Wempty-body]) WINE_TRY_CROSSCFLAGS([-Wignored-qualifiers])
WINE_TRY_CROSSCFLAGS([-Wimplicit-function-declaration]) WINE_TRY_CROSSCFLAGS([-Winit-self]) WINE_TRY_CROSSCFLAGS([-Wpacked-not-aligned],[EXTRACROSSCFLAGS="$EXTRACROSSCFLAGS -Wno-packed-not-aligned"]) WINE_TRY_CROSSCFLAGS([-Wpragma-pack],[EXTRACROSSCFLAGS="$EXTRACROSSCFLAGS -Wno-pragma-pack"])@@ -2016,6 +2017,7 @@ then WINE_TRY_CFLAGS([-Wdeclaration-after-statement]) WINE_TRY_CFLAGS([-Wempty-body]) WINE_TRY_CFLAGS([-Wignored-qualifiers])
- WINE_TRY_CFLAGS([-Wimplicit-function-declaration]) WINE_TRY_CFLAGS([-Winit-self]) WINE_TRY_CFLAGS([-Wpacked-not-aligned],[EXTRACFLAGS="$EXTRACFLAGS -Wno-packed-not-aligned"]) WINE_TRY_CFLAGS([-Wpragma-pack],[EXTRACFLAGS="$EXTRACFLAGS -Wno-pragma-pack"])
Is the intent to work around an actual implicit function declaration (e.g. the one fixed by ed44832c7d?) If so, I'd think we should fix the code instead of adding workarounds.
No the intention of this patch is to have the warnings enabled for all compatible compilers
On 4/9/21 11:47 AM, Dean Greer wrote:
No the intention of this patch is to have the warnings enabled for all compatible compilers
Is there a compiler known that disables those warnings by default? gcc enables it as part of -Wall, so it should already be enabled.
Op vr 9 apr. 2021 om 18:52 schreef Zebediah Figura (she/her) < zfigura@codeweavers.com>:
Is there a compiler known that disables those warnings by default? gcc enables it as part of -Wall, so it should already be enabled.
I sent my previous email by accident, sorry about that.
Op vr 9 apr. 2021 om 18:52 schreef Zebediah Figura (she/her) < zfigura@codeweavers.com>:
Is there a compiler known that disables those warnings by default? gcc enables it as part of -Wall, so it should already be enabled.
IIRC I had to explicitly add -Wimplicit-function-declaration for Clang shipped by XCode 11.
clang-11 and below don’t enabled this by default (not Apple-clang)
My current CFLAGS for compiling wine are “-g -O2 -fPIC -Wall -Wdeclaration-after-statement -Wwrite-strings -Wtype-limits”
Referring to the macOS specific issue from recently Xcode11 didn’t even show a warning nor did upstream clang-11.
On Fri, Apr 9, 2021 at 1:09 PM Gijs Vermeulen gijsvrm@gmail.com wrote:
I sent my previous email by accident, sorry about that.
Op vr 9 apr. 2021 om 18:52 schreef Zebediah Figura (she/her) < zfigura@codeweavers.com>:
Is there a compiler known that disables those warnings by default? gcc enables it as part of -Wall, so it should already be enabled.
IIRC I had to explicitly add -Wimplicit-function-declaration for Clang shipped by XCode 11.
-
Dean Greer -
Gijs Vermeulen -
Zebediah Figura (she/her)