Re: [PATCH 1/3] ntdll: NtCancelIoFile(Ex) enters a nonaleratable wait state instead of an alertable one, this allows system apcs to run but blocks user apcs
Bernhard Loos bernhardloos@googlemail.com writes:
dlls/ntdll/file.c | 4 ++-- dlls/ntdll/tests/file.c | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-)
The whole point of the wait is to run user APCs...
On Fri, Aug 5, 2011 at 4:34 PM, Alexandre Julliard julliard@winehq.org wrote:
Bernhard Loos bernhardloos@googlemail.com writes:
dlls/ntdll/file.c | 4 ++-- dlls/ntdll/tests/file.c | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-)
The whole point of the wait is to run user APCs...
-- Alexandre Julliard julliard@winehq.org
Well, windows doesn't run user apcs at this point, as the tests show. I'm not completly sure, if the wait the nonalertable wait is needed to run system io apc of the cancelled operation, but an alertable wait seems to be wrong.
Bernhard Loos bernhardloos@googlemail.com writes:
Well, windows doesn't run user apcs at this point, as the tests show. I'm not completly sure, if the wait the nonalertable wait is needed to run system io apc of the cancelled operation, but an alertable wait seems to be wrong.
There's no need for a wait to run system APCs. We run user APCs here because they are needed to free memory, so this would have to be changed first.
-
Alexandre Julliard -
Bernhard Loos