From: Michael Stefaniuc mstefani@winehq.org
Signed-off-by: Michael Stefaniuc mstefani@winehq.org Signed-off-by: Matteo Bruni mbruni@codeweavers.com --- v2: Get rid of another unnecessary cast, while at it mildly reformat the lines of code touched.
Michael, I kept your signed-off. Holler if you disagree :D
dlls/d3dxof/parsing.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/dlls/d3dxof/parsing.c b/dlls/d3dxof/parsing.c index f7724ec1913..6f93bfe3ea4 100644 --- a/dlls/d3dxof/parsing.c +++ b/dlls/d3dxof/parsing.c @@ -1208,13 +1208,13 @@ static BOOL parse_object_members_list(parse_buffer * buf) return FALSE; if (pt->members[i].type == TOKEN_WORD) { - *(((WORD*)(buf->pdata + buf->cur_pos_data))) = (WORD)(*(DWORD*)buf->value); - buf->cur_pos_data += 2; + *(WORD *)(buf->pdata + buf->cur_pos_data) = *(DWORD *)buf->value; + buf->cur_pos_data += 2; } else if (pt->members[i].type == TOKEN_DWORD) { - *(((DWORD*)(buf->pdata + buf->cur_pos_data))) = (DWORD)(*(DWORD*)buf->value); - buf->cur_pos_data += 4; + *(DWORD *)(buf->pdata + buf->cur_pos_data) = *(DWORD *)buf->value; + buf->cur_pos_data += 4; } else { @@ -1230,8 +1230,8 @@ static BOOL parse_object_members_list(parse_buffer * buf) return FALSE; if (pt->members[i].type == TOKEN_FLOAT) { - *(((float*)(buf->pdata + buf->cur_pos_data))) = (float)(*(float*)buf->value); - buf->cur_pos_data += 4; + *(float *)(buf->pdata + buf->cur_pos_data) = *(float *)buf->value; + buf->cur_pos_data += 4; } else {
On 2/12/19 6:29 PM, Matteo Bruni wrote:
From: Michael Stefaniuc mstefani@winehq.org
Signed-off-by: Michael Stefaniuc mstefani@winehq.org Signed-off-by: Matteo Bruni mbruni@codeweavers.com
v2: Get rid of another unnecessary cast, while at it mildly reformat the lines of code touched.
Michael, I kept your signed-off. Holler if you disagree :D
After I validated that it is still a no-op you can keep the signed-off ;)
bye michael
dlls/d3dxof/parsing.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)dlls/d3dxof/parsing.c
diff --git a/dlls/d3dxof/parsing.c b/dlls/d3dxof/parsing.c index f7724ec1913..6f93bfe3ea4 100644 --- a/dlls/d3dxof/parsing.c +++ b/dlls/d3dxof/parsing.c @@ -1208,13 +1208,13 @@ static BOOL parse_object_members_list(parse_buffer * buf) return FALSE; if (pt->members[i].type == TOKEN_WORD) {
*(((WORD*)(buf->pdata + buf->cur_pos_data))) = (WORD)(*(DWORD*)buf->value);
buf->cur_pos_data += 2;
*(WORD *)(buf->pdata + buf->cur_pos_data) = *(DWORD *)buf->value;
buf->cur_pos_data += 2; } else if (pt->members[i].type == TOKEN_DWORD) {
*(((DWORD*)(buf->pdata + buf->cur_pos_data))) = (DWORD)(*(DWORD*)buf->value);
buf->cur_pos_data += 4;
*(DWORD *)(buf->pdata + buf->cur_pos_data) = *(DWORD *)buf->value;
buf->cur_pos_data += 4; } else {
@@ -1230,8 +1230,8 @@ static BOOL parse_object_members_list(parse_buffer * buf) return FALSE; if (pt->members[i].type == TOKEN_FLOAT) {
*(((float*)(buf->pdata + buf->cur_pos_data))) = (float)(*(float*)buf->value);
buf->cur_pos_data += 4;
*(float *)(buf->pdata + buf->cur_pos_data) = *(float *)buf->value;
buf->cur_pos_data += 4; } else {