Re: [2/2] user32: Use IsTextUnicode instead of a helper.

[Nikolay Sivov]

On 22.01.2016 10:11, Jactry Zeng wrote:
> - if (!data_looks_unicode( ptr, size ))
> - if (!IsTextUnicode((WCHAR *)ptr, sizeof((WCHAR *)ptr), NULL))

Why it's sizeof() now instead of 'size' ? Also why do you need a cast to
(WCHAR*)?

[2/2] user32: Use IsTextUnicode instead of a helper.

[Jactry Zeng]

Hi,
2016-01-22 16:28 GMT+08:00 Nikolay Sivov :
> On 22.01.2016 10:11, Jactry Zeng wrote:
> > - if (!data_looks_unicode( ptr, size ))
> > - if (!IsTextUnicode((WCHAR *)ptr, sizeof((WCHAR *)ptr), NULL))
>
> Why it's sizeof() now instead of 'size' ? Also why do you need a cast to
> (WCHAR*)?

You are right, I used IsTextUnicode in a wrong way. Thank you Nikolay.
It seems we need to improve data_looks_unicode() instead of using
IsTextUnicode() directly.

Please ignore the second patch.