Re: comctl32: TOOLBAR_SetImageList should recalulate toolbar only if it is necessary

[Alexandre Julliard]

Igor Tarasov  writes:
> Forgot the patch :)
>
> 2009/4/19 Igor Tarasov :
> > Currently TOOLBAR_SetImageList recalculates toolbar and button sizes
> > even if there is no need in this (when new image list bitmap sizes are
> > equal to toolbar bitmap sizes). This overwrites button sizes that
> > might have been defined by application, and thus leads to visual
> > glitches. Native comctl does not change any toolbar sizes on
> > TB_SETIMAGELIST when bitmap size is the same.

It doesn't work here:

../../../tools/runtest -q -P wine -M comctl32.dll -T ../../.. -p comctl32_test.exe.so toolbar.c && touch toolbar.ok
toolbar.c:934: Test failed: Unexpected button size
toolbar.c:936: Test failed: Unexpected button size
toolbar.c:944: Test failed: Unexpected button size
toolbar.c:946: Test failed: invalid rect (button) (0,2) (163,40) - expected (0,2) (163,26)
toolbar.c:946: Test failed: invalid rect (button) (163,2) (326,40) - expected (163,2) (326,26)
toolbar.c:946: Test failed: invalid rect (button) (326,2) (489,40) - expected (326,2) (489,26)
toolbar.c:946: Test failed: invalid rect (button) (489,2) (652,40) - expected (489,2) (652,26)
toolbar.c:946: Test failed: invalid rect (button) (652,2) (819,40) - expected (652,2) (819,26)
toolbar.c:946: Test failed: invalid rect (button) (819,2) (850,40) - expected (819,2) (850,26)
toolbar.c:949: Test failed: invalid rect (button) (0,2) (163,40) - expected (0,0) (163,38)
toolbar.c:949: Test failed: invalid rect (button) (163,2) (326,40) - expected (163,0) (326,38)
toolbar.c:949: Test failed: invalid rect (button) (326,2) (489,40) - expected (326,0) (489,38)
toolbar.c:949: Test failed: invalid rect (button) (489,2) (652,40) - expected (489,0) (652,38)
make[2]: *** [toolbar.ok] Error 13

comctl32: TOOLBAR_SetImageList should recalulate toolbar only if it is necessary

[Igor Tarasov]

2009/4/21 Alexandre Julliard :
> It doesn't work here:
>
> ../../../tools/runtest -q -P wine -M comctl32.dll -T ../../.. -p comctl32_test.exe.so toolbar.c && touch toolbar.ok

Thank you for taking time to reply. That was my fault. Going to fix it
add testcase and resend.